From: Trilok Soni <tsoni@codeaurora.org>
To: "Arce, Abraham" <x0066660@ti.com>
Cc: Daniel Walker <dwalker@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arve@android.com
Subject: Re: [PATCH] msm: trout: add keypad support
Date: Thu, 09 Dec 2010 12:32:57 +0530 [thread overview]
Message-ID: <4D007F21.5060602@codeaurora.org> (raw)
In-Reply-To: <AANLkTikOOH3qHHRtqETytYBk_MiCeVBU724CooUYqgdy@mail.gmail.com>
Hi Abraham,
On 12/9/2010 12:04 PM, Arce, Abraham wrote:
>
>> +
>> +static unsigned int trout_col_gpios_evt2[] = { 35, 34, 33, 32, 31, 23, 30, 109 };
>
> WARNING: line over 80 characters
I would leave this to Daniel if he wants to fix it, because by making it under 80 is not
going to improve any code readability, so I prefer to keep it as is.
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: tsoni@codeaurora.org (Trilok Soni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] msm: trout: add keypad support
Date: Thu, 09 Dec 2010 12:32:57 +0530 [thread overview]
Message-ID: <4D007F21.5060602@codeaurora.org> (raw)
In-Reply-To: <AANLkTikOOH3qHHRtqETytYBk_MiCeVBU724CooUYqgdy@mail.gmail.com>
Hi Abraham,
On 12/9/2010 12:04 PM, Arce, Abraham wrote:
>
>> +
>> +static unsigned int trout_col_gpios_evt2[] = { 35, 34, 33, 32, 31, 23, 30, 109 };
>
> WARNING: line over 80 characters
I would leave this to Daniel if he wants to fix it, because by making it under 80 is not
going to improve any code readability, so I prefer to keep it as is.
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-09 7:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 0:24 [PATCH] msm: trout: add keypad support Daniel Walker
2010-12-09 0:24 ` Daniel Walker
2010-12-09 6:34 ` Arce, Abraham
2010-12-09 6:34 ` Arce, Abraham
2010-12-09 6:34 ` Arce, Abraham
2010-12-09 7:02 ` Trilok Soni [this message]
2010-12-09 7:02 ` Trilok Soni
2010-12-09 7:06 ` Trilok Soni
2010-12-09 7:06 ` Trilok Soni
2010-12-09 17:45 ` Daniel Walker
2010-12-09 17:45 ` Daniel Walker
2010-12-09 22:01 ` Arve Hjønnevåg
2010-12-09 22:01 ` Arve Hjønnevåg
2010-12-09 22:01 ` Arve Hjønnevåg
2010-12-09 22:03 ` Daniel Walker
2010-12-09 22:03 ` Daniel Walker
2010-12-09 22:03 ` Daniel Walker
2010-12-10 7:32 ` Trilok Soni
2010-12-10 7:32 ` Trilok Soni
2010-12-10 7:32 ` Trilok Soni
2010-12-10 17:10 ` Daniel Walker
2010-12-10 17:10 ` Daniel Walker
2010-12-13 18:41 ` Daniel Walker
2010-12-13 18:41 ` Daniel Walker
2010-12-13 18:41 ` Daniel Walker
2010-12-14 6:49 ` Trilok Soni
2010-12-14 6:49 ` Trilok Soni
2010-12-14 6:49 ` Trilok Soni
2010-12-15 7:48 ` Pavel Machek
2010-12-15 7:48 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D007F21.5060602@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=arve@android.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.