Re: [PATCH V3 00/11] Add MSM USB controller driver

[Pavan Kondeti <pkondeti@codeaurora.org>]

Hi All,

On 12/7/2010 5:53 PM, Pavankumar Kondeti wrote:
> This patch series adds USB peripheral, host and OTG (role switch based
> on Id pin status) support for MSM SoC. The peripheral controller driver patches
> include splitting ci13xxx_udc into core and bus glue layers. Peripheral
> and Host controller drivers depend on Transceiver driver for clock management
> and low power mode. Peripheral and Host devices are made children of OTG
> device when devices are registered. Runtime PM functions are used by
> Peripheral and Host controller drivers to tell their state to transceiver
> driver which actually takes care of putting hardware into low power mode.
> 
> Change from V2:
> 1. Added core_clock in transceiver driver. This clock is introduced from MSM7x30
> onwards to remove dependency on AXI bus frequency.
> 2. Use debugfs instead of sysfs for role switching option.
> 3. pm_runtime_nocallbacks() is used instead for nop runtime PM methods.
> 4. Peripheral controller driver makes use of ci13xxx_udc core.
> 
> Pavankumar Kondeti (11):
>   USB: Add MSM OTG Controller driver
>   USB: EHCI: Add MSM Host Controller driver
>   USB: EHCI: msm: Add support for power management
>   USB: OTG: msm: Add support for power management
>   USB: gadget: Separate out PCI bus code from ci13xxx_udc
>   USB: gadget: Fix "scheduling while atomic" bugs in ci13xxx_udc
>   USB: gadget: Initialize ci13xxx gadget device's coherent DMA mask
>   USB: gadget: Introduce ci13xxx_udc_driver struct
>   USB: gadget: Add USB controller driver for MSM SoC
>   USB: gadget: Implement runtime PM for ci13xxx gadget
>   USB: gadget: Implement runtime PM for MSM bus glue driver
> 

I have received feedback to re-use the ci13xxx_udc driver when I
submitted a new device controller driver (msm72k_udc.c) for MSM SoC.
http://www.mail-archive.com/linux-arm-msm@vger.kernel.org/msg01111.html

I have split ci13xxx_udc into generic ci13xxx_udc core and PCI bus glue
driver. I have added a new bus glue driver for MSM. We need this bus
glue driver to perform MSM specific quirks after controller is reset and
stopped (i.e after disabling pull-up in device mode). I have verified
ci13xxx_udc driver on MSM SoC. I don't have PCI ci13xxx hardware to test
ci13xxx on PCI. I have not made any changes in PCI driver. So in theory,
these patches should not break PCI driver. It would be really nice if
any one can test 5-11 patches of this series
on PCI ci13xxx hardware.

Thanks in advance,
Pavan

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.