From: Cong Wang <amwang@redhat.com>
To: Neil Horman <nhorman@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jiri Pirko <jpirko@redhat.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
bonding-devel@lists.sourceforge.net,
Jay Vosburgh <fubar@us.ibm.com>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [v3 PATCH 1/2] bonding: sync netpoll code with bridge
Date: Thu, 09 Dec 2010 15:40:30 +0800 [thread overview]
Message-ID: <4D0087EE.90307@redhat.com> (raw)
In-Reply-To: <4D008643.5040500@redhat.com>
On 12/09/10 15:33, Cong Wang wrote:
>>>
>>> /* close slave before restoring its mac address */
>>> dev_close(slave_dev);
>>> @@ -2061,6 +2098,7 @@ static int bond_release_and_destroy(struct
>>> net_device *bond_dev,
>>>
>>> ret = bond_release(bond_dev, slave_dev);
>>> if ((ret == 0)&& (bond->slave_cnt == 0)) {
>>> + bond_dev->priv_flags |= IFF_DISABLE_NETPOLL;
>> Why are you setting IFF_DISABLE_NETPOLL here? That seems unnecessecary
>>
>
> It gets removed in patch 2/2. :)
Oops! I misread IFF_DISABLE_NETPOLL as IFF_IN_NETPOLL...
I think there is a small window between bond_release() and unregister_netdevice(),
setting this could prevent netpoll is setup again on this bond?
next prev parent reply other threads:[~2010-12-09 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 7:52 [v3 PATCH 1/2] bonding: sync netpoll code with bridge Amerigo Wang
2010-12-08 7:52 ` [v3 PATCH 2/2] netpoll: remove IFF_IN_NETPOLL flag Amerigo Wang
2010-12-08 8:16 ` Changli Gao
2010-12-08 8:36 ` Cong Wang
2010-12-08 8:49 ` Changli Gao
2010-12-08 8:52 ` Cong Wang
2010-12-08 13:57 ` [v3 PATCH 1/2] bonding: sync netpoll code with bridge Neil Horman
2010-12-09 7:33 ` Cong Wang
2010-12-09 7:40 ` Cong Wang [this message]
2010-12-15 10:52 ` Cong Wang
2010-12-15 11:59 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0087EE.90307@redhat.com \
--to=amwang@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=fubar@us.ibm.com \
--cc=herbert@gondor.hengli.com.au \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.