Hi Dara, >> If not, then using an enum defined in include/cdma-voicecall.h would be >> better. One major benefit of defining a dedicated enum for CDMA is the >> compiler checking that all enum values are being handled. If you re-use >> the GSM version you would have to resort to using default statements. >> This causes you to lose that extra compiler sanity checking, not to >> mention is against rule M12 of the coding style. And yes I know we're >> not always consistent with this one ;) >> > > This is our preference- we can move the cdma enum from /src/common.h > into include/cdma-voicecall.h if you would prefer that location? I'm fine with doing that. Regards, -Denis