From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] KVM: Fix OSXSAVE after migration
Date: Thu, 09 Dec 2010 12:04:16 +0200 [thread overview]
Message-ID: <4D00A9A0.3030600@redhat.com> (raw)
In-Reply-To: <201012090917.42363.sheng@linux.intel.com>
On 12/09/2010 03:17 AM, Sheng Yang wrote:
> > > if (!is_long_mode(vcpu)&& is_pae(vcpu)) {
> > >
> > > load_pdptrs(vcpu, vcpu->arch.walk_mmu, vcpu->arch.cr3);
> > > mmu_reset_needed = 1;
> >
> > We really should use kvm_set_crX() here.
>
> Yeah, I suppose we use ops->set_cr4() here because we don't need to all kinds of
> check and operation for the value(which should already be done by other S/R code),
> so I just add update_cpuid() here.
>
IIRC the reason is that there are ordering constraints for kvm_set_crX
(and kvm_set_efer). We should do a kvm_set_crs() which sets them all at
once.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-12-09 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 2:49 [PATCH] KVM: Fix OSXSAVE after migration Sheng Yang
2010-12-08 10:33 ` Avi Kivity
2010-12-09 1:17 ` Sheng Yang
2010-12-09 10:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D00A9A0.3030600@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.