From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: [PATCH] libxl: Use xenbus to communicate with xenstore if the socket fails Date: Thu, 9 Dec 2010 10:06:17 +0000 Message-ID: <4D00AA19.30205@eu.citrix.com> References: <1291886276.13966.4612.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1291886276.13966.4612.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Mihir Nanavati , xen-devel List-Id: xen-devel@lists.xenproject.org On 09/12/10 09:17, Ian Campbell wrote: > On Wed, 2010-12-08 at 20:47 +0000, Mihir Nanavati wrote: >> Adds an open xenstore connection function which tries to use the >> xenbus interface (xs_domain_open) when the socket interface >> (xs_daemon_opn) fails. > > I like the concept of this patch. > > I can't think of any reason why the callers of libxenstore should need > to care about how which communication channel gets used so there's no > reason for the library to defer that choice to the caller. So perhaps we > should go one step further push this behaviour down into libxenstore > itself? i.e. add "xs_open(int ro)" and make > xs_{daemon,domain}_open{,_readonly} compatibility aliases to that > function. Unfortunately, there is practical difference between the socket and the page interface. Which is the reason why every xs connection in xapi are sockets; IIRC polling for events on the page interface didn't really work; I think there was at least 1 other practical differences, but it seems to have eluded me. -- Vincent