From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>,
netfilter-devel <netfilter-devel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: ctnetlink loop
Date: Thu, 09 Dec 2010 11:39:56 +0100 [thread overview]
Message-ID: <4D00B1FC.60801@netfilter.org> (raw)
In-Reply-To: <20101208203121.GB23668@mail.eitzenberger.org>
On 08/12/10 21:31, Holger Eitzenberger wrote:
> Hi,
>
>> Holger, this replay -EAGAIN loop in nfnetlink processing was added by
>> Pablo to handle module loading properly, I think. So it might not be
>> safe to just unilaterally remove it.
>
> thanks for your reply!
>
> Pablo, do we really need the replay loop really?
Yes, we need it for the on-demand module loading.
> I now have several
> boxes with problems due to this replay. 'perf report' always gives me
> something like:
>
> 18.88% ulogd [kernel]
> [k] __nla_put
> 10.73% ulogd [kernel]
> [k] nla_parse
> 8.72% ulogd [kernel]
> [k] __nla_reserve
> 6.64% ulogd [kernel]
> [k] nla_put
> 5.14% ulogd [kernel]
> [k] validate_nla
> 5.03% ulogd [kernel]
> [k] pskb_expand_head
> 4.92% ulogd [kernel]
> [k] ctnetlink_fill_info [nf_conntrack_netlink]
> 3.07% ulogd [kernel]
> [k] skb_put
> 3.03% ulogd [kernel]
> [k] ctnetlink_dump_counters [nf_conntrack
>
> And 'strace' shows me that ulogd is stuck in its 'select' call.
Sorry, I missed your previous emails. Why do you think that this related
to -EAGAIN in nfnetlink?
next prev parent reply other threads:[~2010-12-09 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 17:50 ctnetlink loop David Miller
2010-12-08 20:31 ` Holger Eitzenberger
2010-12-09 10:39 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-03 13:39 Holger Eitzenberger
2010-12-03 13:58 ` Holger Eitzenberger
2010-12-09 10:56 ` Pablo Neira Ayuso
2010-12-09 15:23 ` Holger Eitzenberger
2010-12-10 22:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D00B1FC.60801@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.