From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Hema HK <hemahk@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 4/7] mfd: TWL6030: OMAP4: Registering the TWL6030-usb device
Date: Thu, 09 Dec 2010 15:46:44 +0300 [thread overview]
Message-ID: <4D00CFB4.60901@ru.mvista.com> (raw)
In-Reply-To: <1291824116-7143-1-git-send-email-hemahk@ti.com>
Hello.
On 08-12-2010 19:01, Hema HK wrote:
> Registering the twl6030-usb transceiver device as a child to twl6030 core.
> Removed the NOP transceiver init call from board file.
> Populated twl4030_usb_data platform data structure with the function
> pointers for OMAP4430 internal PHY operation to be used twl630-usb driver.
^ by?
> Signed-off-by: Hema HK<hemahk@ti.com>
> Cc: Samuel Ortiz<sameo@linux.intel.com>
> Cc: Felipe Balbi<balbi@ti.com>
> Cc: Tony Lindgren<tony@atomide.com>
[...]
> Index: linux-2.6/drivers/mfd/twl-core.c
> ===================================================================
> --- linux-2.6.orig/drivers/mfd/twl-core.c
> +++ linux-2.6/drivers/mfd/twl-core.c
[...]
> @@ -682,6 +683,43 @@ add_children(struct twl4030_platform_dat
[...]
> + child = add_child(0, "twl6030_usb",
> + pdata->usb, sizeof(*pdata->usb),
> + true,
> + /* irq1 = VBUS_PRES, irq0 = USB ID*/
You forgot space before */.
> Index: linux-2.6/arch/arm/mach-omap2/board-omap4panda.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-omap2/board-omap4panda.c
> +++ linux-2.6/arch/arm/mach-omap2/board-omap4panda.c
Your patch is not sorted.
WBR, Sergei
next prev parent reply other threads:[~2010-12-09 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 16:01 [PATCH 4/7] mfd: TWL6030: OMAP4: Registering the TWL6030-usb device Hema HK
2010-12-09 12:46 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-08 8:30 Hema HK
2010-12-08 0:11 Hema HK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D00CFB4.60901@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=balbi@ti.com \
--cc=hemahk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.