From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36174 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQhTN-0002vR-Ad for qemu-devel@nongnu.org; Thu, 09 Dec 2010 09:27:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQhTJ-0002w6-DQ for qemu-devel@nongnu.org; Thu, 09 Dec 2010 09:27:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQhTJ-0002vk-68 for qemu-devel@nongnu.org; Thu, 09 Dec 2010 09:27:49 -0500 Message-ID: <4D00E79C.20801@redhat.com> Date: Thu, 09 Dec 2010 15:28:44 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1291900645-10661-1-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1291900645-10661-1-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v5 0/2] Clean up img_create() and introduce strtosz_suffix() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, stefanha@linux.vnet.ibm.com Am 09.12.2010 14:17, schrieb Jes.Sorensen@redhat.com: > From: Jes Sorensen > > This patch set introduces strtosz_suffix() which is needed to be able > to use strtosz parsing with a non MB default suffix. This is used to > clean up qemu-img.c:img_create(). > > Kevin asked me to rebase this instead of applying the other patches on > top, so please discard the previous versions. Sorry for the patch > noise. > > v5 fixes the two issues pointed out by Stefan, making the call in > strtosz() explicitly use STRTOSZ_DEFSUFFIX_MB instead of 0 to specify > the default and adds a named argument to the prototype for > strtosz_suffix(). > > Jes Sorensen (2): > Introduce strtosz_suffix() > qemu-img.c: Clean up handling of image size in img_create() > > cutils.c | 17 ++++++++++++++--- > qemu-common.h | 7 +++++++ > qemu-img.c | 23 +++++++++++++++++------ > 3 files changed, 38 insertions(+), 9 deletions(-) Thanks, applied all to the block branch. Kevin