From: "H. Peter Anvin" <hpa@zytor.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: x86@kernel.org, linux-acpi@vger.kernel.org, lenb@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ACPI: Bug compatibility for Windows on the ACPI reboot vector
Date: Thu, 09 Dec 2010 14:36:26 -0800 [thread overview]
Message-ID: <4D0159EA.90303@zytor.com> (raw)
In-Reply-To: <1291931204-5854-3-git-send-email-mjg@redhat.com>
On 12/09/2010 01:46 PM, Matthew Garrett wrote:
> Windows ignores the bit_offset and bit_width, despite the spec requiring
> that they be validated. Drop the checks so that we match this behaviour.
> Windows also goes straight for the keyboard controller if the ACPI reboot
> fails, so we shouldn't sleep if we're still alive.
>
> Signed-off-by: Matthew Garrett<mjg@redhat.com>
Be careful: the goal isn't bug-compatibility with Windows, the goal is
to work on the maximum number of systems. Bug-compatibility with
Windows *may* be a way to that goal, but it is not a guarantee, since
Windows doesn't get validated against older systems that went through
WHQL under an earlier version of Windows.
-hpa
next prev parent reply other threads:[~2010-12-09 22:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 21:46 [PATCH 1/3] X86: Revamp reboot behaviour to match Windows more closely Matthew Garrett
2010-12-09 21:46 ` [PATCH 2/3] ACPICA: Fix access width for reset vector Matthew Garrett
2010-12-09 22:41 ` Rafael J. Wysocki
2010-12-09 23:12 ` H. Peter Anvin
2010-12-09 23:26 ` Matthew Garrett
2010-12-09 21:46 ` [PATCH 3/3] ACPI: Bug compatibility for Windows on the ACPI reboot vector Matthew Garrett
2010-12-09 22:36 ` H. Peter Anvin [this message]
2010-12-09 22:41 ` Rafael J. Wysocki
2010-12-09 22:25 ` [PATCH 1/3] X86: Revamp reboot behaviour to match Windows more closely H. Peter Anvin
2010-12-09 22:32 ` Matthew Garrett
2010-12-09 22:32 ` H. Peter Anvin
2010-12-09 22:38 ` Matthew Garrett
2010-12-09 22:40 ` H. Peter Anvin
2010-12-09 22:51 ` Matthew Garrett
2010-12-09 22:53 ` H. Peter Anvin
2010-12-09 22:58 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0159EA.90303@zytor.com \
--to=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.