From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v4] usb: musb: Adding names for IRQs in resource structure Date: Fri, 10 Dec 2010 15:56:27 +0300 Message-ID: <4D02237B.2070708@mvista.com> References: <1285777599-24245-1-git-send-email-hemahk@ti.com> <8762xo62b5.fsf@deeprootsystems.com> <4D012F2C.9060303@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Kalliguddi, Hema" Cc: Kevin Hilman , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi , Tony Lindgren , "Cousson, Benoit" , Paul Walmsley , Mike Frysinger List-Id: linux-omap@vger.kernel.org Hello. On 10-12-2010 7:46, Kalliguddi, Hema wrote: >>>> The resource data is getting automatically populated from a set of data >>>> generated from TI's hardware database for the OMAP platform, While we >>>> could hack in some exceptions to that tool to generate resources >>>> in a specific order, it seems less fragile to use the resource name >>>> instead.That way, no matter what order the resources are generated, the >>>> driver still work. >>>> Modified the OMAP,Blackfin and Davinci architecture files to add the name >>>> of the IRQs >>>> in the resource structures and musb driver to use the get_irq_byname() >>>> api to >>>> get the device and dma irq numbers instead of using the index. >>>> Signed-off-by: Hema HK >>>> Cc: Felipe Balbi >>>> Cc: Tony Lindgren >>>> Cc: Kevin Hilman >>>> Cc: Cousson, Benoit >>>> Cc: Paul Walmsley >>>> Cc: Mike Frysinger >>>> --- >>> For the davinci changes: >>> Acked-by: Kevin Hilman >>> Kevin >> [...] >>>> Index: linux-omap-pm/arch/arm/mach-davinci/usb.c >>>> =================================================================== >>>> --- linux-omap-pm.orig/arch/arm/mach-davinci/usb.c >>>> +++ linux-omap-pm/arch/arm/mach-davinci/usb.c >>>> @@ -64,10 +64,12 @@ static struct resource usb_resources[] = >>>> { >>>> .start = IRQ_USBINT, >>>> .flags = IORESOURCE_IRQ, >>>> + .name = "mc" >>>> }, >>>> { >>>> /* placeholder for the dedicated CPPI IRQ */ >>>> .flags = IORESOURCE_IRQ, >>>> + .name = "dma" >>>> }, >>>> }; >> Argh! This failed to also modify da8xx_usb20_resources[]... :-( > I think when I posted these patch, da8xx support was not there in mainline. No, it was added long ago, before the glue layer itself. > I will send patch to add this. I will care about this myself now. > Regards, > Hema WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html