From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 6/8 V3] usb: otg: TWL6030: Add twl6030_usb file for compilation
Date: Fri, 10 Dec 2010 16:28:58 +0300 [thread overview]
Message-ID: <4D022B1A.8090705@ru.mvista.com> (raw)
In-Reply-To: <1291984837-26002-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
Hello.
On 10-12-2010 15:40, Hema HK wrote:
> Add the twl6030_usb transceiver file for compilation.
> Signed-off-by: Hema HK<hemahk-l0cyMroinI0@public.gmane.org>
> Cc: Felipe Balbi<balbi-l0cyMroinI0@public.gmane.org>
> Index: usb/drivers/usb/otg/Makefile
> ===================================================================
> --- usb.orig/drivers/usb/otg/Makefile
> +++ usb/drivers/usb/otg/Makefile
> @@ -12,6 +12,7 @@ obj-$(CONFIG_USB_OTG_UTILS) += otg.o
> obj-$(CONFIG_USB_GPIO_VBUS) += gpio_vbus.o
> obj-$(CONFIG_ISP1301_OMAP) += isp1301_omap.o
> obj-$(CONFIG_TWL4030_USB) += twl4030-usb.o
> +obj-$(CONFIG_TWL6030_USB) += twl6030-usb.o
Why not do it in the patch 3, along with adding the Kconfig entry?! Or
even in patch 2, along with the driver itself? Why "smear" these simple things
it over N patches?!
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-12-10 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 12:40 [PATCH 6/8 V3] usb: otg: TWL6030: Add twl6030_usb file for compilation Hema HK
[not found] ` <1291984837-26002-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2010-12-10 13:28 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D022B1A.8090705@ru.mvista.com \
--to=sshtylyov-igf4poytycdqt0dzr+alfa@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=hemahk-l0cyMroinI0@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.