Re: [PATCH v4] usb: musb: Adding names for IRQs in resource structure

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Hello.

On 10-12-2010 16:20, Felipe Balbi wrote:

>>>>>> The resource data is getting automatically populated from a set of data
>>>>>> generated from TI's hardware database for the OMAP platform, While we
>>>>>> could hack in some exceptions to that tool to generate resources
>>>>>> in a specific order, it seems less fragile to use the resource name
>>>>>> instead.That way, no matter what order the resources are generated, the
>>>>>> driver still work.

>>>>>> Modified the OMAP,Blackfin and Davinci architecture files to add the name
>>>>>> of the IRQs
>>>>>> in the resource structures and musb driver to use the get_irq_byname()
>>>>>> api to
>>>>>> get the device and dma irq numbers instead of using the index.

>>>>>> Signed-off-by: Hema HK<hemahk-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Felipe Balbi<balbi-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Tony Lindgren<tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>>>>> Cc: Kevin Hilman<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>>>>>> Cc: Cousson, Benoit<b-cousson-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Paul Walmsley<paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
>>>>>> Cc: Mike Frysinger<vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
>>>>>> ---

>>>>> For the davinci changes:

>>>>> Acked-by: Kevin Hilman<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>

>>>>> Kevin

>>>> [...]

>>>>>> Index: linux-omap-pm/arch/arm/mach-davinci/usb.c
>>>>>> ===================================================================
>>>>>> --- linux-omap-pm.orig/arch/arm/mach-davinci/usb.c
>>>>>> +++ linux-omap-pm/arch/arm/mach-davinci/usb.c
>>>>>> @@ -64,10 +64,12 @@ static struct resource usb_resources[] =
>>>>>> {
>>>>>> .start = IRQ_USBINT,
>>>>>> .flags = IORESOURCE_IRQ,
>>>>>> + .name = "mc"
>>>>>> },
>>>>>> {
>>>>>> /* placeholder for the dedicated CPPI IRQ */
>>>>>> .flags = IORESOURCE_IRQ,
>>>>>> + .name = "dma"
>>>>>> },
>>>>>> };

>>>> Argh! This failed to also modify da8xx_usb20_resources[]... :-(

>>> I think when I posted these patch, da8xx support was not there in mainline.

>> No, it was added long ago, before the glue layer itself.

>>> I will send patch to add this.

>> I will care about this myself now.

> Thanks, send me the patch and I'll put to the same branch.

    I was thinking about pushing this thru the DaVinci tree. Well, I'll post 
to both lists and let you figure out who will apply it... :-)

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html