Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Hello.

On 11-12-2010 20:43, Greg KH wrote:

>>>>>> Removed the board_data parameter being passed to musb_platform_init function
>>>>>> as board data can be extracted from device structure which is already member of
>>>>>> musb structure.

>>>>>> Signed-off-by: Hema HK<hemahk-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Felipe Balbi<balbi-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Tony Lindgren<tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>>>>> Cc: Kevin Hilman<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>>>>>> Cc: Cousson, Benoit<b-cousson-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Paul Walmsley<paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>

>>>>> For the davinci changes:

>>>>> Acked-by: Kevin Hilman<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>

>>>>> Kevin

>>>>>> ---
>>>>>> drivers/usb/musb/blackfin.c  |    2 +-
>>>>>> drivers/usb/musb/davinci.c   |    2 +-
>>>>>> drivers/usb/musb/musb_core.c |    2 +-
>>>>>> drivers/usb/musb/musb_core.h |    2 +-
>>>>>> drivers/usb/musb/omap2430.c  |    6 ++++--
>>>>>> drivers/usb/musb/tusb6010.c  |    2 +-
>>>>>> 6 files changed, 9 insertions(+), 7 deletions(-)

>>>>     Grr. This misses changes to da8xx.c and am35x.c -- which breaks
>>>> the compilation for them!
>>>>     Greg, could you drop it from your usb-next branch? Or should we
>>>> send a patch adding these glue layers?

>>> I can't drop patches from a git branch, sorry, it doesn't work that way
>>> anymore.

>>     OTOH, you could revert it (as breaking the build). Dunno if that
>> makes sense...

> Again, I trust the musb maintainer here to handle this type of thing,
> not me.  So take it up with him.

    Done already. And he's on the CC here too...

> thanks,

> greg k-h

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html