From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Date: Sun, 12 Dec 2010 14:50:04 +0000 Subject: Re: [PATCH] exofs: Remove redundant unlikely() Message-Id: <4D04E11C.6070809@panasas.com> List-Id: References: <1291906521-1087-1-git-send-email-tklauser@distanz.ch> In-Reply-To: <1291906521-1087-1-git-send-email-tklauser@distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On 12/09/2010 04:55 PM, Tobias Klauser wrote: > IS_ERR() already implies unlikely(), so it can be omitted here. > > Signed-off-by: Tobias Klauser > --- > fs/exofs/super.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/exofs/super.c b/fs/exofs/super.c > index 79c3ae6..b2b12a8 100644 > --- a/fs/exofs/super.c > +++ b/fs/exofs/super.c > @@ -488,7 +488,7 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, > } > > od = osduld_info_lookup(&odi); > - if (unlikely(IS_ERR(od))) { > + if (IS_ERR(od)) { > ret = PTR_ERR(od); > EXOFS_ERR("ERROR: device requested is not found " > "osd_name-%s =>%d\n", odi.osdname, ret); I've applied it in my local tree, it'll be included in the next linux-next version I release. For the next merge window. Thanks. Good catch Boaz