From: Ike Panhc <ike.pan@canonical.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 0/7] ideapad: hotkey enablement
Date: Mon, 13 Dec 2010 16:49:28 +0800 [thread overview]
Message-ID: <4D05DE18.3060500@canonical.com> (raw)
In-Reply-To: <AANLkTimUpXe34tSzvOJ_oo=fyqdAhwkk6xnN10BbdWrH@mail.gmail.com>
On 12/09/2010 04:39 PM, Corentin Chary wrote:
>> acpi_handle is still a global variable becuase we need to pass handle pointer
>> to rfk_set with its opcode but only one data argument available.
>
> Of course there is only one data argument available, but since it's a
> void *, you
> can use a struct with your handle and the opcode :).
>
I have tried it. It needs to copy the same handle three times to each struture.
Since we only have an acpi handle, I think to have it global will let driver
easy read.
prev parent reply other threads:[~2010-12-13 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 7:56 [PATCH v2 0/7] ideapad: hotkey enablement Ike Panhc
2010-12-09 7:56 ` Ike Panhc
2010-12-09 7:56 ` [PATCH 1/7] ideapad: add platform driver for ideapad Ike Panhc
2010-12-09 17:04 ` Dave Hansen
2010-12-09 7:56 ` [PATCH 2/7] ideapad: let camera power control entry under platform driver Ike Panhc
2010-12-09 7:57 ` [PATCH 3/7] ideapad: add hotkey support Ike Panhc
2010-12-09 7:57 ` [PATCH 4/7] ideapad: select INPUT_SPARSEKMAP Ike Panhc
2010-12-09 8:13 ` Dmitry Torokhov
2010-12-09 7:57 ` [PATCH 5/7] ideapad: add markups, unify comments and return result when init Ike Panhc
2010-12-09 7:57 ` Ike Panhc
2010-12-09 7:57 ` [PATCH 6/7] ideapad: pass ideapad_priv as argument (part 1) Ike Panhc
2010-12-09 7:57 ` [PATCH 7/7] ideapad: pass ideapad_priv as argument (part 2) Ike Panhc
2010-12-09 8:39 ` [PATCH v2 0/7] ideapad: hotkey enablement Corentin Chary
2010-12-13 8:49 ` Ike Panhc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D05DE18.3060500@canonical.com \
--to=ike.pan@canonical.com \
--cc=corentin.chary@gmail.com \
--cc=dave@linux.vnet.ibm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.