Re: [PATCH v2 1/2] input: keyboard: MCS5080: support suspend/resume.

["Kim, HeungJun" <riverful.kim@samsung.com>]

Hi Dmitry,

2010-12-13 오후 6:00, Dmitry Torokhov 쓴 글:
> Hi Kim,
> 
> On Fri, Nov 19, 2010 at 03:22:18PM +0900, Kim, HeungJun wrote:
>> This patch supports suspend/resume functions for mcs5080 touchkey
>> driver.
>>
> ...
> 
>> @@ -181,6 +188,9 @@ static int __devinit mcs_touchkey_probe(struct i2c_client *client,
>>  		goto err_free_irq;
>>  
>>  	i2c_set_clientdata(client, data);
>> +
>> +	pm_runtime_set_active(&client->dev);
>> +
> 
> Why is this required? Won't this effectively disable PM suspend/resume?

Actually, this part marks system as "ACTIVE". 
So, I know that, if there is not this part, the pm framework skip previous suspend() or rumtime-pm suspend(),
when the system into suspend doing like, # echo mem > /sys/power/state.
Then, this part is needed I think.

If I'm wrong, let me know.

Thank.

Regards,
HeungJun Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html