All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 3/5] kvm/svm: enhance mov DR intercept handler
Date: Mon, 13 Dec 2010 14:14:56 +0200	[thread overview]
Message-ID: <4D060E40.60308@redhat.com> (raw)
In-Reply-To: <1291989088-1380-4-git-send-email-andre.przywara@amd.com>

On 12/10/2010 03:51 PM, Andre Przywara wrote:
> Newer SVM implementations provide the GPR number in the VMCB, so
> that the emulation path is no longer necesarry to handle debug
> register access intercepts. Implement the handling in svm.c and
> use it when the info is provided.
>
> +
> +	if (!err)
> +		skip_emulated_instruction(&svm->vcpu);
> +	else
> +		kvm_inject_gp(&svm->vcpu, 0);
> +

This repeats, how about using complete_insn_gp()?

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2010-12-13 12:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 13:51 [PATCH -v2 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-10 13:51 ` [PATCH 1/5] kvm/svm: add new SVM feature bit names Andre Przywara
2010-12-10 13:51 ` [PATCH 2/5] kvm/svm: enhance MOV CR intercept handler Andre Przywara
2010-12-13 12:13   ` Avi Kivity
2010-12-20 11:56   ` Marcelo Tosatti
2010-12-20 13:20     ` Andre Przywara
2010-12-10 13:51 ` [PATCH 3/5] kvm/svm: enhance mov DR " Andre Przywara
2010-12-13 12:14   ` Avi Kivity [this message]
2010-12-16 12:07     ` Andre Przywara
2010-12-16 12:48       ` Avi Kivity
2010-12-10 13:51 ` [PATCH 4/5] kvm/svm: implement enhanced INVLPG intercept Andre Przywara
2010-12-10 13:51 ` [PATCH 5/5] kvm/svm: copy instruction bytes from VMCB Andre Przywara
2010-12-13 12:24   ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2010-12-07 10:59 [PATCH 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-07 10:59 ` [PATCH 3/5] kvm/svm: enhance mov DR intercept handler Andre Przywara
2010-12-07 11:02   ` Alexander Graf
2010-12-07 13:14     ` Avi Kivity
2010-12-07 13:25   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D060E40.60308@redhat.com \
    --to=avi@redhat.com \
    --cc=andre.przywara@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.