From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH v2 4/8] OMAP4: clock data: Add missing fields in iva_hsd_byp_clk_mux_ck Date: Mon, 13 Dec 2010 14:14:10 +0100 Message-ID: <4D061C22.9020405@ti.com> References: <1291932820-11163-1-git-send-email-b-cousson@ti.com> <1291932820-11163-5-git-send-email-b-cousson@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:59285 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757588Ab0LMNOT (ORCPT ); Mon, 13 Dec 2010 08:14:19 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: "Bergsagel, Jonathan" , "khilman@deeprootsystems.com" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Nayak, Rajendra" Hi Paul, On 12/11/2010 1:34 AM, Paul Walmsley wrote: > On Thu, 9 Dec 2010, Benoit Cousson wrote: > >> From: Jonathan Bergsagel >> >> Add register address, mask and link to the clksel structure that >> were missing in the IVA DPLL mux clock node. >> >> Signed-off-by: Jonathan Bergsagel >> Signed-off-by: Benoit Cousson > > This patch results in a checkpatch warning: > > --- > > WARNING: please, no space before tabs > #23: FILE: arch/arm/mach-omap2/clock44xx_data.c:639: > +^I.clksel ^I= iva_hsd_byp_clk_mux_sel,$ > > total: 0 errors, 1 warnings, 0 checks, 13 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > --- > > I've fixed it in the copy in my local branch, but next time, please run > checkpatch.pl and fix any problems before submitting. Oops, that's my mistake. the original patch was good, and I messed it up during the merge conflict resolution. And then on top of that I completely missed this warning due to the important number of "line over 80 characters" warnings in this series. I have now a "filter for dummies" to remove that and avoid missing real warnings in the future. Thanks, Benoit From mboxrd@z Thu Jan 1 00:00:00 1970 From: b-cousson@ti.com (Cousson, Benoit) Date: Mon, 13 Dec 2010 14:14:10 +0100 Subject: [PATCH v2 4/8] OMAP4: clock data: Add missing fields in iva_hsd_byp_clk_mux_ck In-Reply-To: References: <1291932820-11163-1-git-send-email-b-cousson@ti.com> <1291932820-11163-5-git-send-email-b-cousson@ti.com> Message-ID: <4D061C22.9020405@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On 12/11/2010 1:34 AM, Paul Walmsley wrote: > On Thu, 9 Dec 2010, Benoit Cousson wrote: > >> From: Jonathan Bergsagel >> >> Add register address, mask and link to the clksel structure that >> were missing in the IVA DPLL mux clock node. >> >> Signed-off-by: Jonathan Bergsagel >> Signed-off-by: Benoit Cousson > > This patch results in a checkpatch warning: > > --- > > WARNING: please, no space before tabs > #23: FILE: arch/arm/mach-omap2/clock44xx_data.c:639: > +^I.clksel ^I= iva_hsd_byp_clk_mux_sel,$ > > total: 0 errors, 1 warnings, 0 checks, 13 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > --- > > I've fixed it in the copy in my local branch, but next time, please run > checkpatch.pl and fix any problems before submitting. Oops, that's my mistake. the original patch was good, and I messed it up during the merge conflict resolution. And then on top of that I completely missed this warning due to the important number of "line over 80 characters" warnings in this series. I have now a "filter for dummies" to remove that and avoid missing real warnings in the future. Thanks, Benoit