All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: yocto@yoctoproject.org
Subject: Re: [PATCH 0/1] bug#565: adding environment files
Date: Mon, 13 Dec 2010 11:12:27 -0800	[thread overview]
Message-ID: <4D06701B.807@linux.intel.com> (raw)
In-Reply-To: <cover.1292242072.git.lianhao.lu@intel.com>

On 12/13/2010 04:07 AM, Lianhao Lu wrote:
> I rebased the previous patch of adding package of environment files to
> be compatible with the new cross-canadian.bbclass
>
Lianhao,

This may require Richard to look at a little more closely, I do notice 
that you are missing the LIC_FILES_CHKSUM, for this on you can use one 
similar to recipes-core/tasks/task-base.bb

The first line of the commit message synopsis needs to be more 
descriptive, and the bug id needs to be in the commit message so that we 
can parse it out later.

Synopsis is normally
<recipe | file> : Synopsis

Example:
meta-environment: Added package of meta-environment-${TARGET_ARCH} for 
environment files.

In the body of the commit message you can add the bug id according to 
this format:

[BUGID# NNN], where NNN is the bugid

Please fix these issues and resubmit, also you should use the 
poky@yoctoproject.org for bug submissions.

Sau!

> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: llu/bug565
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=llu/bug565
>
> Thanks,
>      Lianhao Lu<lianhao.lu@intel.com>
> ---
>
>
> Lianhao Lu (1):
>    Fix bug #565.
>
>   meta/classes/toolchain-scripts.bbclass         |   32 ++++++++++
>   meta/recipes-core/meta/meta-environment.bb     |   74 ++++++++++++++++++++++++
>   meta/recipes-core/tasks/task-cross-canadian.bb |    1 +
>   3 files changed, 107 insertions(+), 0 deletions(-)
>   create mode 100644 meta/recipes-core/meta/meta-environment.bb
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>



  parent reply	other threads:[~2010-12-13 19:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-13 12:07 [PATCH 0/1] bug#565: adding environment files Lianhao Lu
2010-12-13 10:47 ` [PATCH 1/1] Fix bug #565 Lianhao Lu
2010-12-13 19:12 ` Saul Wold [this message]
2010-12-16  1:58   ` [PATCH 0/1] bug#565: adding environment files Lu, Lianhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D06701B.807@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.