From: Lars-Peter Clausen <lars@metafoo.de>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/20] mfd: jz4740-adc: irq_data conversion.
Date: Mon, 13 Dec 2010 21:45:52 +0100 [thread overview]
Message-ID: <4D068600.4030405@metafoo.de> (raw)
In-Reply-To: <20101213123043.GR15575@mail.wantstofly.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi
There was already a similar patch yesterday:
https://lkml.org/lkml/2010/12/12/111
Thanks,
- - Lars
On 12/13/2010 01:30 PM, Lennert Buytenhek wrote:
> Signed-off-by: Lennert Buytenhek <buytenh@secretlab.ca>
> ---
> drivers/mfd/jz4740-adc.c | 25 +++++++++++++------------
> 1 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index 9dd1b33..955b0d0 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -84,31 +84,32 @@ static inline void jz4740_adc_irq_set_masked(struct jz4740_adc *adc, int irq,
> spin_unlock_irqrestore(&adc->lock, flags);
> }
>
> -static void jz4740_adc_irq_mask(unsigned int irq)
> +static void jz4740_adc_irq_mask(struct irq_data *d)
> {
> - struct jz4740_adc *adc = get_irq_chip_data(irq);
> - jz4740_adc_irq_set_masked(adc, irq, true);
> + struct jz4740_adc *adc = irq_data_get_irq_chip_data(d);
> + jz4740_adc_irq_set_masked(adc, d->irq, true);
> }
>
> -static void jz4740_adc_irq_unmask(unsigned int irq)
> +static void jz4740_adc_irq_unmask(struct irq_data *d)
> {
> - struct jz4740_adc *adc = get_irq_chip_data(irq);
> - jz4740_adc_irq_set_masked(adc, irq, false);
> + struct jz4740_adc *adc = irq_data_get_irq_chip_data(d);
> + jz4740_adc_irq_set_masked(adc, d->irq, false);
> }
>
> -static void jz4740_adc_irq_ack(unsigned int irq)
> +static void jz4740_adc_irq_ack(struct irq_data *d)
> {
> - struct jz4740_adc *adc = get_irq_chip_data(irq);
> + struct jz4740_adc *adc = irq_data_get_irq_chip_data(d);
> + unsigned int irq;
>
> - irq -= adc->irq_base;
> + irq = d->irq - adc->irq_base;
> writeb(BIT(irq), adc->base + JZ_REG_ADC_STATUS);
> }
>
> static struct irq_chip jz4740_adc_irq_chip = {
> .name = "jz4740-adc",
> - .mask = jz4740_adc_irq_mask,
> - .unmask = jz4740_adc_irq_unmask,
> - .ack = jz4740_adc_irq_ack,
> + .irq_mask = jz4740_adc_irq_mask,
> + .irq_unmask = jz4740_adc_irq_unmask,
> + .irq_ack = jz4740_adc_irq_ack,
> };
>
> static void jz4740_adc_irq_demux(unsigned int irq, struct irq_desc *desc)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk0Ghf8ACgkQBX4mSR26RiMr4ACeJpqumfCY2TOrQQRTNVW7atwn
yJAAn37a/pAJl/Gih1quoNuI+tgtje9z
=QOer
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-12-13 20:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1292241952.git.buytenh@wantstofly.org>
2010-12-13 12:29 ` [PATCH 01/20] mfd: 88pm860x-core: irq_data conversion Lennert Buytenhek
2010-12-13 12:29 ` [PATCH 02/20] mfd: ab3550: " Lennert Buytenhek
2010-12-13 12:29 ` [PATCH 03/20] mfd: ab8500: " Lennert Buytenhek
2010-12-13 12:30 ` [PATCH 04/20] mfd: asic3: " Lennert Buytenhek
2010-12-13 12:30 ` [PATCH 05/20] mfd: ezx-pcap: " Lennert Buytenhek
2010-12-13 12:30 ` [PATCH 06/20] mfd: htc-egpio: " Lennert Buytenhek
2010-12-13 12:30 ` [PATCH 07/20] mfd: htc-i2cpld: " Lennert Buytenhek
2010-12-13 12:30 ` [PATCH 08/20] mfd: jz4740-adc: " Lennert Buytenhek
2010-12-13 20:45 ` Lars-Peter Clausen [this message]
2010-12-13 12:30 ` [PATCH 09/20] mfd: max8925: " Lennert Buytenhek
2010-12-13 12:30 ` [PATCH 10/20] mfd: max8998: " Lennert Buytenhek
2010-12-14 0:24 ` Kyungmin Park
2010-12-13 12:31 ` [PATCH 11/20] mfd: stmpe: " Lennert Buytenhek
2010-12-14 4:58 ` Rabin Vincent
2010-12-13 12:31 ` [PATCH 12/20] mfd: t7l66xb: " Lennert Buytenhek
2010-12-13 12:31 ` [PATCH 13/20] mfd: tc35892: " Lennert Buytenhek
2010-12-13 12:31 ` [PATCH 14/20] mfd: tc6393xb: " Lennert Buytenhek
2010-12-13 12:31 ` [PATCH 15/20] mfd: tps6586x: " Lennert Buytenhek
2010-12-13 12:58 ` Mike Rapoport
2010-12-13 12:31 ` [PATCH 16/20] mfd: twl4030: " Lennert Buytenhek
2010-12-13 12:31 ` [PATCH 17/20] mfd: twl6030: " Lennert Buytenhek
2010-12-13 12:53 ` Santosh Shilimkar
2010-12-20 1:04 ` Samuel Ortiz
2010-12-13 12:31 ` [PATCH 18/20] mfd: wm831x: " Lennert Buytenhek
2010-12-13 12:39 ` Mark Brown
2010-12-14 9:15 ` Lennert Buytenhek
2010-12-20 0:33 ` Samuel Ortiz
2010-12-13 12:31 ` [PATCH 19/20] mfd: wm8350: " Lennert Buytenhek
2010-12-13 12:31 ` [PATCH 20/20] mfd: wm8994: " Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D068600.4030405@metafoo.de \
--to=lars@metafoo.de \
--cc=buytenh@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.