From: Suraj Sumangala <suraj@Atheros.com>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [RFC] Bluetooth: Use non-flushable pb flag by default for ACL data on capable chipsets.
Date: Tue, 14 Dec 2010 12:04:10 +0530 [thread overview]
Message-ID: <4D070FE2.6000404@Atheros.com> (raw)
In-Reply-To: <1292251105-31130-2-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On 12/13/2010 8:08 PM, Emeltchenko Andrei wrote:
> static inline void l2cap_send_cmd(struct l2cap_conn *conn, u8 ident, u8 code, u16 len, void *data)
> {
> struct sk_buff *skb = l2cap_build_cmd(conn, code, ident, len, data);
> + u8 flags;
>
> BT_DBG("code 0x%2.2x", code);
>
> if (!skb)
> return;
>
> - hci_send_acl(conn->hcon, skb, 0);
> + if (lmp_no_flush_capable(conn->hcon->hdev))
> + flags = ACL_START_NO_FLUSH;
> + else
> + flags = ACL_START;
> +
> + hci_send_acl(conn->hcon, skb, flags);
> }
>
Should we send L2CAP command packets also as flushable packets? Should
it be non-flushable?
I thought only L2CAP data frames should be sent as flushable.
Regards
Suraj
next prev parent reply other threads:[~2010-12-14 6:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 14:38 [RFC] Allow Bluez to select flushable or non-flushable ACL packets Emeltchenko Andrei
2010-12-13 14:38 ` [RFC] Bluetooth: Use non-flushable pb flag by default for ACL data on capable chipsets Emeltchenko Andrei
2010-12-14 6:34 ` Suraj Sumangala [this message]
2010-12-14 19:22 ` Gustavo F. Padovan
2010-12-15 16:35 ` Mat Martineau
2010-12-16 9:00 ` Andrei Emeltchenko
2010-12-16 14:40 ` Andrei Emeltchenko
2010-12-16 17:03 ` Mat Martineau
2010-12-17 7:48 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D070FE2.6000404@Atheros.com \
--to=suraj@atheros.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.