All of lore.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@linux.vnet.ibm.com>
To: Jesse Gross <jesse@nicira.com>
Cc: shemminger@vyatta.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: Fixing LRO configuration
Date: Tue, 14 Dec 2010 11:01:35 -0200	[thread overview]
Message-ID: <4D076AAF.5040505@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTimvL2TdD9eYQMLZW65ESKbame818ObzjPYoBhPL@mail.gmail.com>

Hi Jesse,

On 12/12/2010 10:39 PM, Jesse Gross wrote:
> I don't think that this should enable those vlan offloading flags.
I just inserted ETH_FLAG_TXVLAN and ETH_FLAG_RXVLAN there because when I 
call ethtool -K ethX lro on/off, it sends the ETH_FLAG_LRO plus the vlan 
flags if they are enabled (and they are by default).

So, if it doesn't make sense to be toggled, I can mask these flags at 
ehea_set_flags(). so that it doesn't arrive at ethtool_op_set_flags().

Does it sound better to you ?

Thanks
Breno



  reply	other threads:[~2010-12-14 13:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 18:31 [PATCH] ehea: Fixing LRO configuration leitao
2010-12-08 18:44 ` Ben Hutchings
2010-12-08 18:51   ` leitao
2010-12-08 20:19     ` David Miller
2010-12-13  0:39 ` Jesse Gross
2010-12-14 13:01   ` Breno Leitao [this message]
2010-12-14 20:55     ` Jesse Gross
2010-12-20 19:02       ` [PATCH] ehea: Avoid changing vlan flags leitao
2010-12-28 21:51         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D076AAF.5040505@linux.vnet.ibm.com \
    --to=leitao@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=jesse@nicira.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.