From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH 3/6] xen-gntdev: Remove unneeded structures from grant_map tracking data
Date: Tue, 14 Dec 2010 13:56:09 -0800 [thread overview]
Message-ID: <4D07E7F9.8080006@goop.org> (raw)
In-Reply-To: <4D07E71B.3020606@tycho.nsa.gov>
On 12/14/2010 01:52 PM, Daniel De Graaf wrote:
> On 12/14/2010 04:15 PM, Jeremy Fitzhardinge wrote:
>> On 12/14/2010 06:55 AM, Daniel De Graaf wrote:
>>> The entire hypercall argument list isn't required; only selected
>>> fields from the hypercall need to be tracked between the ioctl, map,
>>> and unmap operations.
>> Is the rationale of this patch to save memory? If so, how much does it
>> save.
>>
>> (This patch seems sensible in principle, but it doesn't seem to save
>> much complexity.)
>>
>> J
> This will also allow easier testing of what pages need to be unmapped
> (more obvious in the HVM version). I also find it less confusing to
> populate the hypercall arguments immediately before the hypercall, but
> that's likely a matter of opinion. It only saves 46 bytes per page, so
> if it seems more complex it could be dropped.
I like it in general. See the other mail I just sent - you can use the
multicall API to remove all the allocations for the arguments, and that
should help a lot.
J
next prev parent reply other threads:[~2010-12-14 21:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 14:55 [PATCH v2] Userspace grant communication Daniel De Graaf
2010-12-14 14:55 ` [PATCH 1/6] xen-gntdev: Fix circular locking dependency Daniel De Graaf
2010-12-14 21:11 ` Jeremy Fitzhardinge
2010-12-14 21:40 ` Daniel De Graaf
2010-12-15 9:47 ` Ian Campbell
2010-12-16 0:28 ` Jeremy Fitzhardinge
2010-12-16 15:09 ` Stefano Stabellini
2010-12-14 14:55 ` [PATCH 2/6] xen-gntdev: Change page limit to be global instead of per-open Daniel De Graaf
2010-12-14 21:12 ` Jeremy Fitzhardinge
2010-12-14 21:42 ` Daniel De Graaf
2010-12-15 9:50 ` Ian Campbell
2010-12-16 0:27 ` Jeremy Fitzhardinge
2010-12-14 14:55 ` [PATCH 3/6] xen-gntdev: Remove unneeded structures from grant_map tracking data Daniel De Graaf
2010-12-14 21:15 ` Jeremy Fitzhardinge
2010-12-14 21:52 ` Daniel De Graaf
2010-12-14 21:56 ` Jeremy Fitzhardinge [this message]
2010-12-14 21:54 ` Jeremy Fitzhardinge
2010-12-14 14:55 ` [PATCH 4/6] xen-gntdev: Use find_vma rather than iterating our vma list manually Daniel De Graaf
2010-12-14 21:20 ` Jeremy Fitzhardinge
2010-12-15 9:58 ` Ian Campbell
2010-12-16 0:29 ` Jeremy Fitzhardinge
2010-12-14 14:55 ` [PATCH 5/6] xen-gntalloc: Userspace grant allocation driver Daniel De Graaf
2010-12-14 21:42 ` Jeremy Fitzhardinge
2010-12-14 22:06 ` Daniel De Graaf
2010-12-14 22:40 ` Jeremy Fitzhardinge
2010-12-15 14:18 ` Daniel De Graaf
2010-12-16 1:05 ` Jeremy Fitzhardinge
2010-12-16 15:22 ` Daniel De Graaf
2010-12-16 19:14 ` Jeremy Fitzhardinge
2010-12-14 14:55 ` [PATCH 6/6] xen-gntdev: Introduce HVM version of gntdev Daniel De Graaf
2010-12-14 21:45 ` Jeremy Fitzhardinge
2010-12-14 22:27 ` Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D07E7F9.8080006@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.