From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Re-define PKT_PROT_LEN to be bigger.
Date: Tue, 14 Dec 2010 14:17:13 -0800 [thread overview]
Message-ID: <4D07ECE9.9090600@goop.org> (raw)
In-Reply-To: <1292358922-5569-1-git-send-email-paul.durrant@citrix.com>
On 12/14/2010 12:35 PM, Paul Durrant wrote:
> Re-define PKT_PROT_LEN to be big enough to handle maximal IPv4 and TCP options and phrase
> the definition so that it's reasonably obvious that's what it's for.
Which kernel are these for?
Thanks,
J
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> drivers/xen/netback/netback.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c
> index c448675..1a4a20e 100644
> --- a/drivers/xen/netback/netback.c
> +++ b/drivers/xen/netback/netback.c
> @@ -128,7 +128,7 @@ static inline int netif_get_page_ext(struct page *pg, unsigned int *_group, unsi
> * packet processing on them (netfilter, routing, etc). 72 is enough
> * to cover TCP+IP headers including options.
> */
> -#define PKT_PROT_LEN 72
> +#define PKT_PROT_LEN (ETH_HLEN + 4 + (15 * 4) + (15 * 4))
>
> static inline pending_ring_idx_t pending_index(unsigned i)
> {
next prev parent reply other threads:[~2010-12-14 22:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 20:35 [PATCH] Re-define PKT_PROT_LEN to be bigger Paul Durrant
2010-12-14 20:35 ` [PATCH] Don't count packets we don't actually receive Paul Durrant
2010-12-14 20:35 ` [PATCH] Remove the 500ms timeout to restart the netif queue Paul Durrant
2010-12-14 20:35 ` [PATCH] Add a missing test to tx_work_todo Paul Durrant
2010-12-14 20:35 ` [PATCH] Re-factor net_tx_action_dealloc() slightly Paul Durrant
2010-12-15 15:58 ` [PATCH] Remove the 500ms timeout to restart the netif queue Konrad Rzeszutek Wilk
2010-12-16 10:00 ` Paul Durrant
2010-12-14 22:17 ` Jeremy Fitzhardinge [this message]
2010-12-15 9:30 ` [PATCH] Re-define PKT_PROT_LEN to be bigger Paul Durrant
2010-12-15 9:37 ` Ian Campbell
2010-12-20 14:34 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2010-12-15 9:48 Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D07ECE9.9090600@goop.org \
--to=jeremy@goop.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.