From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Wakamiya Subject: Re: [PATCH] pvops: fix "xm save -c" issue Date: Wed, 15 Dec 2010 13:18:06 +0900 Message-ID: <4D08417E.7060104@jp.fujitsu.com> References: <4D070138.7090708@jp.fujitsu.com> <20101214145925.GA5769@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101214145925.GA5769@dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi Konrad, thank you for your response, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote: >> Hi, >> >> I'm investigating the issue of "xm save -c" in case of PV guests. >> Then, I tried to prevent calling dpm_resume_end() when suspend was >> canceled. It seems to work fine about blk and net. >> How about this? > > > Could you give more details of what the failure is? "xm save -c" saves domain state to storage and leaves it running after creating snapshot. When this command is executed for a pvops guest (xen/stable-2.6.32.x), the guest will hang up after accessing to devices. When the guest is unapused, stop_machine() in manage.c returns as the suspend is cancelled. In that case, I think dpm_resume_end() should not be called after stop_machine(). I tested vbd and net, the guest did not hang. But I'm not sure if this is a right way... Thanks, >> Thanks, >> >> Signed-off-by: Kenji Wakamiya >> Signed-off-by: Kazuhiro Suzuki >> -- >> Kenji Wakamiya >> > >> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c >> index 0b50906..3dcc270 100644 >> --- a/drivers/xen/manage.c >> +++ b/drivers/xen/manage.c >> @@ -148,11 +148,10 @@ out_resume: >> if (!cancelled) { >> xen_arch_resume(); >> xs_resume(); >> + dpm_resume_end(PMSG_RESUME); >> } else >> xs_suspend_cancel(); >> >> - dpm_resume_end(PMSG_RESUME); >> - >> /* Make sure timer events get retriggered on all CPUs */ >> clock_was_set(); >> > >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >