From: Jef Driesen <jefdriesen@telenet.be>
To: Robert Lukassen <Robert.Lukassen@tomtom.com>
Cc: Greg KH <greg@kroah.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: g_serial: Allow to override the default VID/PID
Date: Wed, 15 Dec 2010 08:57:47 +0100 [thread overview]
Message-ID: <4D0874FB.8080503@telenet.be> (raw)
In-Reply-To: <D6DB9C7EDECDA944B870F62B587008622C8A4D@NL-EXC-06.intra.local>
On 06/12/10 09:09, Robert Lukassen wrote:
> Yes, providing access to those module parameters was the original goal. I
> agree that my patch should be reverted and I'll try to come up with a method
> of accessing these values without violating the information hiding principles
> too much. I don't like accessing globals.
Do I have to take any action to make sure the original commit [1] gets reverted?
[1] 1ab83238740ff1e1773d5c13ecac43c60cf4aec4
next prev parent reply other threads:[~2010-12-15 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4CE6F807.1090607@telenet.be>
2010-11-19 23:32 ` [PATCH] USB: g_serial: Allow to override the default VID/PID Jef Driesen
2010-11-20 0:12 ` Greg KH
2010-11-20 23:03 ` Jef Driesen
2010-11-22 10:20 ` Robert Lukassen
2010-11-30 17:46 ` Greg KH
2010-12-03 22:09 ` Jef Driesen
2010-12-06 8:09 ` Robert Lukassen
2010-12-15 7:57 ` Jef Driesen [this message]
2010-12-17 0:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0874FB.8080503@telenet.be \
--to=jefdriesen@telenet.be \
--cc=Robert.Lukassen@tomtom.com \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.