ALSA: HDA: Enable subwoofer on Asus G73Jw

ALSA: HDA: Enable subwoofer on Asus G73Jw

[David Henningsson]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

Set default association/sequence right on pin 0x17 in order for
the automatic parser to recognize the subwoofer correctly.

Patch rewritten to fit with the patch applied earlier today; let me know 
if you want the original as well (might suit stable better?).

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

[-- Attachment #2: 0001-ALSA-HDA-Enable-subwoofer-on-Asus-G73Jw.patch --]
[-- Type: text/x-patch, Size: 1573 bytes --]

>From caa3fbacba497e402468acdc7df96e647efe903c Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Wed, 15 Dec 2010 09:18:18 +0100
Subject: [PATCH] ALSA: HDA: Enable subwoofer on Asus G73Jw

Set default association/sequence right on pin 0x17 in order for
the automatic parser to recognize the subwoofer correctly.

Cc: stable@kernel.org
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_realtek.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3aeda3a..3cfce09 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -14809,6 +14809,7 @@ enum {
 	ALC269_FIXUP_SONY_VAIO,
 	ALC269_FIXUP_DELL_M101Z,
 	ALC269_FIXUP_LENOVO_EDGE14,
+	ALC269_FIXUP_ASUS_G73JW,
 };
 
 static const struct alc_fixup alc269_fixups[] = {
@@ -14829,12 +14830,19 @@ static const struct alc_fixup alc269_fixups[] = {
 	[ALC269_FIXUP_LENOVO_EDGE14] = {
 		.sku = ALC_FIXUP_SKU_IGNORE,
 	},
+	[ALC269_FIXUP_ASUS_G73JW] = {
+		.pins = (const struct alc_pincfg[]) {
+			{ 0x17, 0x99130111 }, /* subwoofer */
+			{ }
+		}
+	},
 };
 
 static struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
 	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
 	SND_PCI_QUIRK(0x17aa, 0x21b8, "Thinkpad Edge 14", ALC269_FIXUP_LENOVO_EDGE14),
+	SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
 	{}
 };
 
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: ALSA: HDA: Enable subwoofer on Asus G73Jw

[Takashi Iwai]

At Wed, 15 Dec 2010 09:23:44 +0100,
David Henningsson wrote:
> 
> Set default association/sequence right on pin 0x17 in order for
> the automatic parser to recognize the subwoofer correctly.
> 
> Patch rewritten to fit with the patch applied earlier today; let me know 
> if you want the original as well (might suit stable better?).

Since the patch isn't applied cleanly to stable tree as is, I applied
the patch without Cc to stable.

Could you resend the patch (cleanly applicable one) to stable tree
later once after the next pull to Linus tree is done?


thanks,

Takashi

> -- 
> David Henningsson, Canonical Ltd.
> http://launchpad.net/~diwic
> [2 0001-ALSA-HDA-Enable-subwoofer-on-Asus-G73Jw.patch <text/x-patch (7bit)>]
> >From caa3fbacba497e402468acdc7df96e647efe903c Mon Sep 17 00:00:00 2001
> From: David Henningsson <david.henningsson@canonical.com>
> Date: Wed, 15 Dec 2010 09:18:18 +0100
> Subject: [PATCH] ALSA: HDA: Enable subwoofer on Asus G73Jw
> 
> Set default association/sequence right on pin 0x17 in order for
> the automatic parser to recognize the subwoofer correctly.
> 
> Cc: stable@kernel.org
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3aeda3a..3cfce09 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -14809,6 +14809,7 @@ enum {
>  	ALC269_FIXUP_SONY_VAIO,
>  	ALC269_FIXUP_DELL_M101Z,
>  	ALC269_FIXUP_LENOVO_EDGE14,
> +	ALC269_FIXUP_ASUS_G73JW,
>  };
>  
>  static const struct alc_fixup alc269_fixups[] = {
> @@ -14829,12 +14830,19 @@ static const struct alc_fixup alc269_fixups[] = {
>  	[ALC269_FIXUP_LENOVO_EDGE14] = {
>  		.sku = ALC_FIXUP_SKU_IGNORE,
>  	},
> +	[ALC269_FIXUP_ASUS_G73JW] = {
> +		.pins = (const struct alc_pincfg[]) {
> +			{ 0x17, 0x99130111 }, /* subwoofer */
> +			{ }
> +		}
> +	},
>  };
>  
>  static struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
>  	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
>  	SND_PCI_QUIRK(0x17aa, 0x21b8, "Thinkpad Edge 14", ALC269_FIXUP_LENOVO_EDGE14),
> +	SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
>  	{}
>  };
>  
> -- 
> 1.7.1
> 

Re: ALSA: HDA: Enable subwoofer on Asus G73Jw

[David Henningsson]

On 2010-12-15 09:47, Takashi Iwai wrote:
> At Wed, 15 Dec 2010 09:23:44 +0100,
> David Henningsson wrote:
>>
>> Set default association/sequence right on pin 0x17 in order for
>> the automatic parser to recognize the subwoofer correctly.
>>
>> Patch rewritten to fit with the patch applied earlier today; let me know
>> if you want the original as well (might suit stable better?).
>
> Since the patch isn't applied cleanly to stable tree as is, I applied
> the patch without Cc to stable.
>
> Could you resend the patch (cleanly applicable one) to stable tree
> later once after the next pull to Linus tree is done?

Ok, do you know if I can keep track of when this is done? Or do I just 
have to make a daily check of linux-2.6 to see what's in there?

Thanks,

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

Re: ALSA: HDA: Enable subwoofer on Asus G73Jw

[Takashi Iwai]

At Wed, 15 Dec 2010 09:52:15 +0100,
David Henningsson wrote:
> 
> On 2010-12-15 09:47, Takashi Iwai wrote:
> > At Wed, 15 Dec 2010 09:23:44 +0100,
> > David Henningsson wrote:
> >>
> >> Set default association/sequence right on pin 0x17 in order for
> >> the automatic parser to recognize the subwoofer correctly.
> >>
> >> Patch rewritten to fit with the patch applied earlier today; let me know
> >> if you want the original as well (might suit stable better?).
> >
> > Since the patch isn't applied cleanly to stable tree as is, I applied
> > the patch without Cc to stable.
> >
> > Could you resend the patch (cleanly applicable one) to stable tree
> > later once after the next pull to Linus tree is done?
> 
> Ok, do you know if I can keep track of when this is done? Or do I just 
> have to make a daily check of linux-2.6 to see what's in there?

You can check when the new rc is released.  The sync of stable tree
is done at each time rc is released.

The commit id ac612407932be18697b5ae9da0a80f138b8bea8e should be
kept, so you can check whether this commit id is contained in the
upcoming rc6.


thanks,

Takashi