From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH][TOOLS] libxl: open code basename() Date: Wed, 15 Dec 2010 13:23:54 +0100 Message-ID: <4D08B35A.7060200@ts.fujitsu.com> References: <201012151312.59779.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201012151312.59779.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 12/15/10 13:12, Christoph Egger wrote: > > Hi! > > Attached patch open codes basename() with strrchr(). > Fixes build on platforms like NetBSD where POSIX basename is available. > > Signed-off-by: Christoph Egger > > diff -r dcb46110d460 -r e8ce7e3e4b8c tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -5455,7 +5455,7 @@ int main_cpupoolcreate(int argc, char ** > if (!xlu_cfg_get_string (config, "name", &buf)) > name = strdup(buf); > else > - name = basename(filename); > + name = strrchr(filename, '/') + 1; > if (!libxl_name_to_cpupoolid(&ctx, name, &poolid)) { > fprintf(stderr, "Pool name \"%s\" already exists\n", name); > return -ERROR_FAIL; This is not correct. strrchr returns NULL here if filename contains no '/'. This leads to name being 1. Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html