From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] ccid: add passthru card device
Date: Wed, 15 Dec 2010 13:27:28 +0100 [thread overview]
Message-ID: <4D08B430.1000600@redhat.com> (raw)
In-Reply-To: <1292179059-21617-3-git-send-email-alevy@redhat.com>
Hi,
Commit message could be a bit more verbose, even if it is redundant with
what the patch "1/5" message says. Also short usage information (or
pointer to the file patch "5/5" adds) would be good.
Patch itself looks fine to me.
cheers,
Gerd
next prev parent reply other threads:[~2010-12-15 12:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 18:37 [Qemu-devel] [PATCH 0/5] usb-ccid (v9) Alon Levy
2010-12-12 18:37 ` [Qemu-devel] [PATCH 1/5] usb-ccid: add CCID bus Alon Levy
2010-12-15 12:23 ` Gerd Hoffmann
2010-12-12 18:37 ` [Qemu-devel] [PATCH 2/5] ccid: add passthru card device Alon Levy
2010-12-15 12:27 ` Gerd Hoffmann [this message]
2010-12-12 18:37 ` [Qemu-devel] [PATCH 3/5] libcacard: initial commit after coding style fixes Alon Levy
2010-12-15 12:32 ` Gerd Hoffmann
2010-12-12 18:37 ` [Qemu-devel] [PATCH 4/5] ccid: add ccid-card-emulated device (v2) Alon Levy
2010-12-15 12:37 ` Gerd Hoffmann
2010-12-12 18:37 ` [Qemu-devel] [PATCH 5/5] smartcard: add docs Alon Levy
2010-12-15 12:39 ` Gerd Hoffmann
2010-12-15 12:01 ` [Qemu-devel] [PATCH 0/5] usb-ccid (v9) Gerd Hoffmann
2010-12-15 13:01 ` Alon Levy
-- strict thread matches above, loose matches on Subject: below --
2010-12-16 11:06 [Qemu-devel] [PATCH 0/5] usb-ccid (v10) Alon Levy
2010-12-16 11:06 ` [Qemu-devel] [PATCH 2/5] ccid: add passthru card device Alon Levy
2010-12-16 12:38 ` Gerd Hoffmann
2010-12-17 19:44 [Qemu-devel] [PATCH 0/5] usb-ccid (v11) Alon Levy
2010-12-17 19:44 ` [Qemu-devel] [PATCH 2/5] ccid: add passthru card device Alon Levy
2011-01-03 16:05 [Qemu-devel] [PATCH 0/5] usb-ccid (v12) Alon Levy
2011-01-03 16:05 ` [Qemu-devel] [PATCH 2/5] ccid: add passthru card device Alon Levy
2011-01-06 13:59 [Qemu-devel] [PATCH 0/5] usb-ccid (v13) Alon Levy
2011-01-06 13:59 ` [Qemu-devel] [PATCH 2/5] ccid: add passthru card device Alon Levy
2011-01-08 10:28 [Qemu-devel] [PATCH 0/5] usb-ccid (v14) Alon Levy
2011-01-08 10:28 ` [Qemu-devel] [PATCH 2/5] ccid: add passthru card device Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08B430.1000600@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.