All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Wise <swise-10udUCx4aRo@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: rdma provider module references
Date: Wed, 15 Dec 2010 12:53:40 -0600	[thread overview]
Message-ID: <4D090EB4.70706@aoot.com> (raw)
In-Reply-To: <adapqt3gdzb.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>

On 12/15/2010 11:09 AM, Roland Dreier wrote:
>   >  I notice that if I have a user rdma application running that has an
>   >  rdma connection using iw_cxgb3, then the iw_cxgb3 module reference
>   >  count is bumped and thus it cannot be unloaded.  However when I have
>   >  an NFSRDMA connection that utilizes iw_cxgb3, the module reference
>   >  count is not bumped, and iw_cxgb3 can erroneously be unloaded while
>   >  the NFSRDMA connection is still active, causing a crash.
>
> What is supposed to happen is that as the HW driver is unloading, it
> calls ib_unregister_device() first, and this calls each client's
> .remove() method to have it release everything related to that device.
>
> However I guess NFS/RDMA is behind the RDMA CM, which is supposed to
> handle device removal.  In that code it seems to end up in
> cma_process_remove(), which appears at first glance to do the right
> things to destroy all connections etc.
>
> The idea is that RDMA devices should be like net devices, ie you can
> remove them even if they're in use -- things should just clean up,
> rather than blocking the module removal.  The uverbs case is a bit of a
> hack because we don't have a way to handle revoking the mmap regions
> etc yet.
>

Thanks for the description of how it should work.

> What goes wrong with NFS/RDMA in this scheme?  It looks like it should work.
>

I'm still investigating exactly what happens.  I'll follow up once I know more.

Thanks!

Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-12-15 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-15 16:15 rdma provider module references Steve Wise
     [not found] ` <4D08E989.5020307-10udUCx4aRo@public.gmane.org>
2010-12-15 17:09   ` Roland Dreier
     [not found]     ` <adapqt3gdzb.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-12-15 18:53       ` Steve Wise [this message]
2010-12-16 15:34       ` Steve Wise
2010-12-16 15:48       ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D090EB4.70706@aoot.com \
    --to=swise-10uducx4aro@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.