From: Nishanth Menon <nm@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Vishwanath Sripathy <vishwanath.bs@ti.com>,
linux-omap <linux-omap@vger.kernel.org>,
Eduardo Valentin <eduardo.valentin@nokia.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if < ES1.2
Date: Wed, 15 Dec 2010 18:05:27 -0600 [thread overview]
Message-ID: <4D0957C7.4010907@ti.com> (raw)
In-Reply-To: <87wrnaions.fsf@deeprootsystems.com>
Kevin Hilman had written, on 12/15/2010 05:47 PM, the following:
>> I agree that this additional check in sram_idle should be removed, but
>> as long as I handle it in omap3_pm_off_mode_enable where the next
>> states are configured, is'nt that enough or am I missing something?
>
> Setting the next states only sets the default states, but CPUidle
> changes them.
>
> Looking closer at omap3_pm_off_mode_enable() though, it already calls
> into CPUidle and disables the valid bit for any states that have
> *either* MPU or core off. You'll probably just need to extend this
> approach to disable only CORE off state(s).
Thx. it is clear now. let me see how to clean this up.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-12-16 0:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 17:03 [PATCH 0/5 v3] OMAP: idle path errata fixes Nishanth Menon
2010-12-03 17:03 ` [PATCH 1/5 v2] OMAP3: PM: Update clean_l2 to use v7_flush_dcache_all Nishanth Menon
2010-12-03 17:03 ` [PATCH 2/5 v2] OMAP3: PM: Erratum i581 support: dll kick strategy Nishanth Menon
2010-12-03 17:03 ` [PATCH 3/5 v3] OMAP3630: PM: Erratum i608: disable RTA Nishanth Menon
2010-12-14 3:28 ` Kevin Hilman
2010-12-15 22:13 ` Nishanth Menon
2010-12-16 0:01 ` Kevin Hilman
2010-12-03 17:03 ` [PATCH 4/5 v3] OMAP3630: PM: Disable L2 cache while invalidating L2 cache Nishanth Menon
2010-12-03 17:03 ` [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if < ES1.2 Nishanth Menon
2010-12-13 13:35 ` Vishwanath Sripathy
2010-12-13 13:43 ` Nishanth Menon
2010-12-13 13:54 ` Vishwanath Sripathy
2010-12-13 14:04 ` Nishanth Menon
2010-12-13 14:25 ` Vishwanath Sripathy
2010-12-13 14:36 ` Nishanth Menon
2010-12-13 14:43 ` Nishanth Menon
2010-12-13 14:48 ` Vishwanath Sripathy
2010-12-13 14:52 ` Nishanth Menon
2010-12-13 14:58 ` Vishwanath Sripathy
2010-12-13 15:02 ` Nishanth Menon
2010-12-14 3:42 ` Kevin Hilman
2010-12-15 21:31 ` Nishanth Menon
2010-12-15 23:47 ` Kevin Hilman
2010-12-16 0:05 ` Nishanth Menon [this message]
2010-12-16 1:30 ` Nishanth Menon
2010-12-16 18:57 ` Kevin Hilman
2010-12-17 1:07 ` Nishanth Menon
2010-12-17 22:54 ` Kevin Hilman
2010-12-17 23:09 ` Nishanth Menon
2010-12-20 16:51 ` Kevin Hilman
2010-12-13 14:45 ` Vishwanath Sripathy
2010-12-13 14:47 ` Nishanth Menon
2010-12-08 23:03 ` [PATCH 0/5 v3] OMAP: idle path errata fixes Nishanth Menon
2010-12-14 3:49 ` Kevin Hilman
2010-12-15 21:40 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0957C7.4010907@ti.com \
--to=nm@ti.com \
--cc=eduardo.valentin@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.