From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 4/6] xen-gntdev: Use find_vma rather than
	iterating our vma list manually
Date: Wed, 15 Dec 2010 16:29:35 -0800
Message-ID: <4D095D6F.40400@goop.org>
References: <1292338553-20575-1-git-send-email-dgdegra@tycho.nsa.gov>	<1292338553-20575-5-git-send-email-dgdegra@tycho.nsa.gov>	<4D07DFB2.2040104@goop.org>
	<1292407100.32368.2655.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1292407100.32368.2655.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 12/15/2010 01:58 AM, Ian Campbell wrote:
> On Tue, 2010-12-14 at 21:20 +0000, Jeremy Fitzhardinge wrote:
>> On 12/14/2010 06:55 AM, Daniel De Graaf wrote:
>>> @@ -74,6 +74,8 @@ struct grant_map {
>>>  	struct granted_page pages[0];
>>>  };
>>>  
>>> +static struct vm_operations_struct gntdev_vmops;
>> Is it OK for this to be all NULL?
> It's a forward declaration, the actual definition is later on.

(Ugh, always hated that syntax.)

    J