From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Michael Subject: Re: pipe control notify removed? Date: Thu, 16 Dec 2010 10:23:33 +0800 Message-ID: <4D097825.40907@linux.intel.com> References: <20101215031453.GA29548@zhen-devel.sh.intel.com> <5b55a1$iv0q2i@fmsmga002.fm.intel.com> <20101216015955.GB30083@zhen-devel.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id BEAA89E7BC for ; Wed, 15 Dec 2010 18:23:34 -0800 (PST) In-Reply-To: <20101216015955.GB30083@zhen-devel.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 2010/12/16 9:59, Zhenyu Wang wrote: > On 2010.12.15 10:05:01 +0000, Chris Wilson wrote: >> On Wed, 15 Dec 2010 11:14:53 +0800, Zhenyu Wang wrote: >>> >>> Chris, just notice you removed pipe control notify entirely on -next, >>> that seems wrong to me. In Ironlake time, we've seen interrupt stall issue >>> with user interrupt, and be warned user interrupt is deprecated, so we moved >>> on to use pipe control notify, although there's a workaround later covered >>> that's required on Ironlake. But it's stable finally. And for sandybridge, >>> there's no such workaround needed. >> >> The answer to this is to make sure that such details are kept in the >> code comments, especially if such information is not readily available >> in the documentation. > > yeah, also our spec might not have been updated as well...I'll send the BUN > doc for that to you. > I guess what Chris really want is to leave some comments in the code for such workaround - BUN id isn't very useful to most people anyway. ;) > > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx