All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Vivek Goyal <vgoyal@redhat.com>, Maxim Uvarov <muvarov@gmail.com>,
	linux-kernel@vger.kernel.org, Neil Horman <nhorman@redhat.com>
Subject: Re: kdump broken on 2.6.37-rc4
Date: Wed, 15 Dec 2010 20:29:01 -0800	[thread overview]
Message-ID: <4D09958D.2040907@kernel.org> (raw)
In-Reply-To: <20101215103954.GA2243@redhat.com>

please check

[PATCH] x86, crashkernel, 32bit: only try to get range under 512M

Steanishlaw report kdump is 32bit is broken.

in misc.c for decompresser, it will do sanity checking to make sure heap
heap under 512M.

So limit it in first kernel under 512M for 32bit system.

Reported-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/kernel/setup.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Index: linux-2.6/arch/x86/kernel/setup.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/setup.c
+++ linux-2.6/arch/x86/kernel/setup.c
@@ -499,7 +499,19 @@ static inline unsigned long long get_tot
 	return total << PAGE_SHIFT;
 }
 
+/*
+ * arch/x86/boot/compressed/misc.c will check heap size for decompresser
+ *  32bit will have more strict limitation
+ */
 #define DEFAULT_BZIMAGE_ADDR_MAX 0x37FFFFFF
+#define HEAP_LIMIT_32BIT 0x20000000
+
+#ifdef CONFIG_X86_64
+#define CRASH_KERNEL_LIMIT DEFAULT_BZIMAGE_ADDR_MAX
+#else
+#define CRASH_KERNEL_LIMIT HEAP_LIMIT_32BIT
+#endif
+
 static void __init reserve_crashkernel(void)
 {
 	unsigned long long total_mem;
@@ -521,7 +533,7 @@ static void __init reserve_crashkernel(v
 		 *  kexec want bzImage is below DEFAULT_BZIMAGE_ADDR_MAX
 		 */
 		crash_base = memblock_find_in_range(alignment,
-			       DEFAULT_BZIMAGE_ADDR_MAX, crash_size, alignment);
+			       CRASH_KERNEL_LIMIT, crash_size, alignment);
 
 		if (crash_base == MEMBLOCK_ERROR) {
 			pr_info("crashkernel reservation failed - No suitable area found.\n");

  parent reply	other threads:[~2010-12-16  4:29 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 11:16 kdump broken on 2.6.37-rc4 Stanislaw Gruszka
2010-12-03 11:16 ` Stanislaw Gruszka
2010-12-03 15:46 ` Maxim Uvarov
2010-12-03 15:46   ` Maxim Uvarov
2010-12-03 17:11   ` Stanislaw Gruszka
2010-12-03 17:11     ` Stanislaw Gruszka
2010-12-03 17:54     ` Neil Horman
2010-12-03 17:54       ` Neil Horman
2010-12-07 10:50       ` Stanislaw Gruszka
2010-12-07 10:50         ` Stanislaw Gruszka
2010-12-07 19:24         ` Yinghai Lu
2010-12-07 19:24           ` Yinghai Lu
2010-12-08 14:19           ` Stanislaw Gruszka
2010-12-08 14:19             ` Stanislaw Gruszka
2010-12-09  7:16             ` Yinghai Lu
2010-12-09  7:16               ` Yinghai Lu
2010-12-09 12:41               ` Stanislaw Gruszka
2010-12-09 12:41                 ` Stanislaw Gruszka
2010-12-09 20:09                 ` Yinghai Lu
2010-12-09 20:09                   ` Yinghai Lu
2010-12-13 10:08                   ` Stanislaw Gruszka
2010-12-13 10:08                     ` Stanislaw Gruszka
2010-12-13 18:20                     ` Yinghai Lu
2010-12-13 19:47                       ` H. Peter Anvin
2010-12-14 22:41                         ` Vivek Goyal
2010-12-15 10:39                           ` Stanislaw Gruszka
2010-12-15 22:41                             ` Yinghai Lu
2010-12-16  4:29                             ` Yinghai Lu [this message]
2010-12-16 10:00                               ` Stanislaw Gruszka
2010-12-16 16:16                                 ` H. Peter Anvin
2010-12-16 16:22                                   ` Vivek Goyal
2010-12-16 16:53                                     ` H. Peter Anvin
2010-12-18 21:50                                 ` Yinghai Lu
2010-12-16 14:39                               ` Vivek Goyal
2010-12-16 16:28                                 ` H. Peter Anvin
2010-12-16 17:28                                   ` Yinghai Lu
2010-12-16 19:58                                     ` H. Peter Anvin
2010-12-16 22:57                                       ` Yinghai Lu
2010-12-16 23:30                                       ` Yinghai Lu
2010-12-16 23:49                                         ` Yinghai Lu
2010-12-17  0:39                                           ` Yinghai Lu
2010-12-17  1:06                                             ` H. Peter Anvin
2010-12-17  1:21                                             ` H. Peter Anvin
2010-12-17  1:51                                             ` H. Peter Anvin
2010-12-17  3:05                                               ` Yinghai Lu
2010-12-17  3:07                                               ` Yinghai Lu
2010-12-17  3:19                                                 ` [tip:x86/urgent] x86-32: Make sure we can map all of lowmem if we need to tip-bot for H. Peter Anvin
2010-12-17 14:33                                                   ` Stanislaw Gruszka
2010-12-16 22:01                                     ` kdump broken on 2.6.37-rc4 Vivek Goyal
2010-12-16 22:58                                       ` Yinghai Lu
2010-12-17 16:15                                         ` Vivek Goyal
2010-12-17  1:15                                       ` H. Peter Anvin
2010-12-17  3:31                               ` H. Peter Anvin
2010-12-17  3:58                                 ` Yinghai
2010-12-17  4:08                                   ` H. Peter Anvin
2010-12-17  4:46                                     ` Yinghai Lu
2010-12-17  5:16                                       ` H. Peter Anvin
2010-12-17 17:01                                   ` Vivek Goyal
2010-12-17 17:56                                     ` H. Peter Anvin
2010-12-17 18:02                                       ` Vivek Goyal
2010-12-17 18:21                                         ` Yinghai Lu
2010-12-17 18:35                                           ` Vivek Goyal
2010-12-17 19:39                                           ` H. Peter Anvin
2010-12-17 19:46                                             ` Yinghai Lu
2010-12-17 19:50                                               ` Vivek Goyal
2010-12-17 19:52                                                 ` Yinghai Lu
2010-12-17 20:01                                                   ` Vivek Goyal
2010-12-17 20:06                                                     ` Yinghai Lu
2010-12-17 20:34                                                       ` Vivek Goyal
2010-12-17 23:51                                                         ` Vivek Goyal
2010-12-17 19:56                                                 ` H. Peter Anvin
2010-12-17 20:11                                                   ` Vivek Goyal
2010-12-17 20:59                                                     ` H. Peter Anvin
2010-12-17 21:13                                                       ` Vivek Goyal
2010-12-20 16:31                                                   ` Stanislaw Gruszka
2010-12-18  4:34                                                 ` [tip:x86/urgent] x86, kexec: Limit the crashkernel address appropriately tip-bot for H. Peter Anvin
2010-12-17 19:50                                               ` kdump broken on 2.6.37-rc4 H. Peter Anvin
2010-12-13 10:25                   ` Américo Wang
2010-12-13 10:25                     ` Américo Wang
2010-12-05 14:35 ` Maciej Rutecki
2010-12-05 14:35   ` Maciej Rutecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D09958D.2040907@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=muvarov@gmail.com \
    --cc=nhorman@redhat.com \
    --cc=sgruszka@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.