From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Wakamiya Subject: Re: [PATCH] pvops: fix "xm save -c" issue Date: Thu, 16 Dec 2010 14:49:54 +0900 Message-ID: <4D09A882.5070504@jp.fujitsu.com> References: <4D070138.7090708@jp.fujitsu.com> <20101214145925.GA5769@dumpdata.com> <4D08417E.7060104@jp.fujitsu.com> <20101215154021.GB28984@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101215154021.GB28984@dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi Konrad, Konrad Rzeszutek Wilk wrote: >> When the guest is unapused, stop_machine() in manage.c returns as the >> suspend is cancelled. In that case, I think dpm_resume_end() should >> not be called after stop_machine(). >> >> I tested vbd and net, the guest did not hang. > > OK. Does 'xm save' (so no -c) and then resume work with this patch > (I would think so, but I am curious whether you tested this). > >> But I'm not sure if this is a right way... > > Looks OK to me, just want to make sure that the normal 'xm save' still > works after this. I tested normal 'xm save' with this patch, and made sure it works well. When normal save/restore is performed, the domain is suspended without cancel, unlike 'save -c'. So, dpm_resume_end() is called. This scenario haven't changed even after applying this patch. Thanks, -- Kenji Wakamiya