From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ew0-f45.google.com ([209.85.215.45]:46532 "EHLO mail-ew0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456Ab0LPMkh (ORCPT ); Thu, 16 Dec 2010 07:40:37 -0500 Message-ID: <4D0A0887.4030901@ru.mvista.com> Date: Thu, 16 Dec 2010 15:39:35 +0300 From: Sergei Shtylyov MIME-Version: 1.0 Subject: Re: [RFC v2 4/4] USB: Eliminate delays involved in root hub initialization during HNP References: <1292497742-2618-1-git-send-email-pkondeti@codeaurora.org> <1292497742-2618-5-git-send-email-pkondeti@codeaurora.org> In-Reply-To: <1292497742-2618-5-git-send-email-pkondeti@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Pavankumar Kondeti Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org Hello. On 16-12-2010 14:09, Pavankumar Kondeti wrote: > Some USB controllers have common resources (IRQ, register address > space) for Host, Peripheral and OTG. So HCD is added only before > entering into Host mode. Root hub initialization is done in > different steps to decrease boot up time. But this makes B-device > difficult to meet HNP timings. Hence eliminate delays involved in > root hub initialization for B-host. > This patch also marks hnp_supported flag TRUE for B-host while > registering the bus. > Change-Id: I821775e8c90bd71a7abbe17176f189664a1841e1 > Signed-off-by: Pavankumar Kondeti [...] > index ac79fd5..2df61ba 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -680,6 +680,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type) > int status; > bool need_debounce_delay = false; > unsigned delay; > + bool hnp_in_progress = hdev->bus->is_b_host&& (type == HUB_INIT); Parens here are not necessary. WBR, Sergei