From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52136 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTDKB-0000jE-Mh for qemu-devel@nongnu.org; Thu, 16 Dec 2010 07:52:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTDKA-0000Gh-8t for qemu-devel@nongnu.org; Thu, 16 Dec 2010 07:52:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTDK9-0000GL-UT for qemu-devel@nongnu.org; Thu, 16 Dec 2010 07:52:46 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBGCqj1N002235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Dec 2010 07:52:45 -0500 Message-ID: <4D0A0B9B.1090004@redhat.com> Date: Thu, 16 Dec 2010 13:52:43 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/5] libcacard: initial commit after coding style fixes References: <1292497600-16115-1-git-send-email-alevy@redhat.com> <1292497600-16115-4-git-send-email-alevy@redhat.com> In-Reply-To: <1292497600-16115-4-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 12/16/10 12:06, Alon Levy wrote: > libcacard emulates a Common Access Card (CAC) which is a standard > for smartcards. It is used by the emulated ccid card introduced in > a following patch. Docs are available in docs/libcacard.txt Looks good to me, although I'm not a crypto expert. Most of the critical crypto stuff is in nss anyway though, so: Acked-by: Gerd Hoffmann cheers, Gerd