From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-ey0-f171.google.com ([209.85.215.171]:63435 "EHLO
	mail-ey0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751449Ab0LPNS4 (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Thu, 16 Dec 2010 08:18:56 -0500
Message-ID: <4D0A1183.8060506@ru.mvista.com>
Date: Thu, 16 Dec 2010 16:17:55 +0300
From: Sergei Shtylyov <sshtylyov@mvista.com>
MIME-Version: 1.0
Subject: Re: [RFC v2 4/4] USB: Eliminate delays involved in root hub initialization
 during HNP
References: <1292497742-2618-1-git-send-email-pkondeti@codeaurora.org> <1292497742-2618-5-git-send-email-pkondeti@codeaurora.org> <4D0A0887.4030901@ru.mvista.com> <20101216130756.GE6652@legolas.emea.dhcp.ti.com>
In-Reply-To: <20101216130756.GE6652@legolas.emea.dhcp.ti.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-arm-msm-owner@vger.kernel.org
List-ID: <linux-arm-msm.vger.kernel.org>
To: balbi@ti.com
Cc: Sergei Shtylyov <sshtylyov@mvista.com>, Pavankumar Kondeti <pkondeti@codeaurora.org>, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org

On 16-12-2010 16:07, Felipe Balbi wrote:

>>> Some USB controllers have common resources (IRQ, register address
>>> space) for Host, Peripheral and OTG. So HCD is added only before
>>> entering into Host mode. Root hub initialization is done in
>>> different steps to decrease boot up time. But this makes B-device
>>> difficult to meet HNP timings. Hence eliminate delays involved in
>>> root hub initialization for B-host.

>>> This patch also marks hnp_supported flag TRUE for B-host while
>>> registering the bus.

>>> Change-Id: I821775e8c90bd71a7abbe17176f189664a1841e1
>>> Signed-off-by: Pavankumar Kondeti<pkondeti@codeaurora.org>
>> [...]

>>> index ac79fd5..2df61ba 100644
>>> --- a/drivers/usb/core/hub.c
>>> +++ b/drivers/usb/core/hub.c
>>> @@ -680,6 +680,7 @@ static void hub_activate(struct usb_hub *hub, enum
>>> hub_activation_type type)
>>> int status;
>>> bool need_debounce_delay = false;
>>> unsigned delay;
>>> + bool hnp_in_progress = hdev->bus->is_b_host&& (type == HUB_INIT);

>> Parens here are not necessary.

> there's also a missing space before &&

    That's my Thunderbird eating spaces before &. :-)

WBR, Sergei