Re: [PATCH 14/14] t{3032,6038}-*.sh: Allow SED_BIN_OPT to override the -b sed option

[Ramsay Jones <ramsay@ramsay1.demon.co.uk>]

Junio C Hamano wrote:
>>  
>> -test_have_prereq SED_STRIPS_CR && SED_OPTIONS=-b
>> +test_have_prereq SED_STRIPS_CR && SED_OPTIONS=${SED_BIN_OPT--b}
> 
> It is unclear who is supposed to feed you SED_BIN_OPT.
> 
> Perhaps a patch to add an insn like "If you have an ancient sed, export
> SED_BIN_OPT=-c before running tests" to t/README is also necessary to go
> together with this change.

Yes, you are right. I had such a change to t/README but it was mixed in with
another patch to document other such variables which was incomplete. (see my
previous mail in response to your comments on patch 4/14).

Also, I was half expecting you to drop the patch, because I thought I was in
the minority with an old sed; however, it seems I'm not that unusual after
all ... ;-)

ATB,
Ramsay Jones