From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: fix type-punning warnings
Date: Thu, 16 Dec 2010 14:39:38 -0600 [thread overview]
Message-ID: <4D0A790A.1080703@redhat.com> (raw)
In-Reply-To: <20101215230926.GC4455@thunk.org>
On 12/15/2010 05:09 PM, Ted Ts'o wrote:
> On Tue, Dec 14, 2010 at 01:00:01PM -0600, Eric Sandeen wrote:
>> Flags used during RHEL/Fedora builds lead to a couple type-punning
>> warnings:
>>
>> recovery.c: In function 'do_one_pass':
>> recovery.c:539: warning: dereferencing type-punned pointer will break strict-aliasing rules
>> ./csum.c: In function 'print_csum':
>> ./csum.c:170: warning: dereferencing type-punned pointer will break strict-aliasing rules
>>
>> The two changes below fix this up.
>>
>> Note that the csum test binary output changes slightly, but this does
>> not break any tests.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Thanks, applied. There's also a bone-headed big-endian compile bug
> which means I'll be doing an e2fsprogs 1.41.14 shortly.
>
> - Ted
Hm this may need an include of the e2p.h header as well, if built in
a pristine buildroot...
--- e2fsprogs-1.41.12.orig/lib/ext2fs/csum.c
+++ e2fsprogs-1.41.12/lib/ext2fs/csum.c
@@ -17,6 +17,7 @@
#include "ext2_fs.h"
#include "ext2fs.h"
#include "crc16.h"
+#include "e2p/e2p.h"
#include <assert.h>
#ifndef offsetof
Sorry about that,
-Eric
next prev parent reply other threads:[~2010-12-16 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 19:00 [PATCH] e2fsprogs: fix type-punning warnings Eric Sandeen
2010-12-15 18:53 ` Edward Shishkin
2010-12-15 23:09 ` Ted Ts'o
2010-12-16 20:39 ` Eric Sandeen [this message]
2010-12-16 22:15 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0A790A.1080703@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.