All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: fw_printenv supports mmc device
Date: Fri, 17 Dec 2010 11:58:19 +0900	[thread overview]
Message-ID: <4D0AD1CB.4010904@samsung.com> (raw)
In-Reply-To: <AANLkTinzyzekmvvN7tTjRRZJrcgKv8cCcfXUh3f-3cR5@mail.gmail.com>

 On 2010-12-17 ?? 3:45 , Steve Sakoman wrote:
> On Wed, Dec 15, 2010 at 5:22 PM, Donghwa Lee <dh09.lee@samsung.com> wrote:
>> I modified fw_printenv tools to use /dev/mmcblk0 node. Original fw_printenv tool
>> can be access MTD devices, but, in some cases, environment variables can be stored
>> other memory devices, for example, mmc devices.
>> So, I modified a few code to use /dev/mmcblk0.
> I submitted a similar patch series from Lo?c Minier a couple of weeks ago:
>
> http://old.nabble.com/-U-Boot---RFC-0-3--Enhance-env-tools-td30373328.html
>
> I've been working a a v2 to address the comments received.
>
> Do you think a variant of that patch series will work for you?
>
> Perhaps we could combine efforts for a patch series to solve the mmc
> and normal file write targets?
>
> Steve
>

I think your ideas are quite similar to me. I tested your patch to my target.

In my kernel your patch can not recognize file type, but, when 'is_mtd' is 0, it work well.


Best regards,
Donghwa lee

  reply	other threads:[~2010-12-17  2:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16  1:22 [U-Boot] [PATCH] tools: fw_printenv supports mmc device Donghwa Lee
2010-12-16  6:42 ` Stefano Babic
2010-12-17  2:34   ` Donghwa Lee
2010-12-16 18:45 ` Steve Sakoman
2010-12-17  2:58   ` Donghwa Lee [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-12-16  1:20 y at samsung.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0AD1CB.4010904@samsung.com \
    --to=dh09.lee@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.