From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lai Jiangshan Subject: Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError Date: Fri, 17 Dec 2010 14:20:15 +0800 Message-ID: <4D0B011F.8060502@cn.fujitsu.com> References: <4D088F27.8000909@cn.fujitsu.com> <20101215150911.14e1693f@doriath> <4D08F868.5090100@redhat.com> <20101215152606.078147ad@doriath> <20101215160000.16f85795@doriath> <4D09D5EA.7070000@redhat.com> <20101216084815.3ca77188@doriath> <4D0A0B00.3070108@redhat.com> <20101216110917.646779b7@doriath> <4D0A1016.7060408@redhat.com> <20101216111752.77757c00@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Markus Armbruster , qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org To: Luiz Capitulino Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:56274 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752054Ab0LQGTL (ORCPT ); Fri, 17 Dec 2010 01:19:11 -0500 In-Reply-To: <20101216111752.77757c00@doriath> Sender: kvm-owner@vger.kernel.org List-ID: On 12/16/2010 09:17 PM, Luiz Capitulino wrote: > On Thu, 16 Dec 2010 15:11:50 +0200 > Avi Kivity wrote: >> >> Why have an argument at all? Always nmi to all cpus. > I think Avi's suggest is better, and I will use "inject-nmi" (without cpu-index argument) to send NMI to all cpus, like physical GUI. If some one want to send NMI to a set of cpus, he can use "inject-nmi" multiple times. I also like "cpu-index", so I have to add another patch for coverting current "cpu_index" to "cpu-index". Thanks, Lai From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40770 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTTey-0003do-Cb for qemu-devel@nongnu.org; Fri, 17 Dec 2010 01:19:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTTex-0006yj-DW for qemu-devel@nongnu.org; Fri, 17 Dec 2010 01:19:20 -0500 Received: from [222.73.24.84] (port=54178 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTTew-0006yB-UN for qemu-devel@nongnu.org; Fri, 17 Dec 2010 01:19:19 -0500 Message-ID: <4D0B011F.8060502@cn.fujitsu.com> Date: Fri, 17 Dec 2010 14:20:15 +0800 From: Lai Jiangshan MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError References: <4D088F27.8000909@cn.fujitsu.com> <20101215150911.14e1693f@doriath> <4D08F868.5090100@redhat.com> <20101215152606.078147ad@doriath> <20101215160000.16f85795@doriath> <4D09D5EA.7070000@redhat.com> <20101216084815.3ca77188@doriath> <4D0A0B00.3070108@redhat.com> <20101216110917.646779b7@doriath> <4D0A1016.7060408@redhat.com> <20101216111752.77757c00@doriath> In-Reply-To: <20101216111752.77757c00@doriath> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, Avi Kivity , kvm@vger.kernel.org, Markus Armbruster On 12/16/2010 09:17 PM, Luiz Capitulino wrote: > On Thu, 16 Dec 2010 15:11:50 +0200 > Avi Kivity wrote: >> >> Why have an argument at all? Always nmi to all cpus. > I think Avi's suggest is better, and I will use "inject-nmi" (without cpu-index argument) to send NMI to all cpus, like physical GUI. If some one want to send NMI to a set of cpus, he can use "inject-nmi" multiple times. I also like "cpu-index", so I have to add another patch for coverting current "cpu_index" to "cpu-index". Thanks, Lai