All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler once only
Date: Fri, 17 Dec 2010 14:12:34 +0100	[thread overview]
Message-ID: <4D0B61C2.7010106@redhat.com> (raw)
In-Reply-To: <1292514846-4612-1-git-send-email-stefanha@linux.vnet.ibm.com>

Am 16.12.2010 16:54, schrieb Stefan Hajnoczi:
> We register the vm change state handler in a PCI BAR map() function.
> This function can be called multiple times throughout the lifetime of a
> PCI IDE device.  This results in duplicate vm change state handlers
> being register, none of which are ever unregistered.
> 
> Instead, register the vm change state handler in the device's init
> function once and for all.
> 
> piix tested, cmd646 and via not tested.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

Kevin

  reply	other threads:[~2010-12-17 13:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16 15:54 [Qemu-devel] [PATCH v2] ide: Register vm change state handler once only Stefan Hajnoczi
2010-12-17 13:12 ` Kevin Wolf [this message]
2010-12-17 18:35   ` [Qemu-devel] " Andreas Färber
2010-12-17 18:44     ` [Qemu-devel] [PATCH] ide: Fix build for cmd646.c Kevin Wolf
2010-12-17 18:55       ` [Qemu-devel] " Andreas Färber
2010-12-17 18:46     ` [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler once only Kevin Wolf
2010-12-17 18:54       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0B61C2.7010106@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.