From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45210 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PTc2e-0000MQ-KY
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 10:16:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PTc2d-00023b-0b
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 10:16:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46471)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PTc2c-00023X-Of
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 10:16:18 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBHFGH6V027567
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 17 Dec 2010 10:16:17 -0500
Message-ID: <4D0B7F09.2030000@redhat.com>
Date: Fri, 17 Dec 2010 16:17:29 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1292598160-21698-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1292598160-21698-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 0/2] qcow2 cleanups
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org

Am 17.12.2010 16:02, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Hi,
> 
> These two patches tries to clean up the qcow2 code a little. First
> makes the function names consistent, ie. we shouldn't have qcow_
> functions in the qcow2 code. Second tries to add proper errno return
> values to qcow2_open().
> 
> New in v2: Fix the bdrv_pread() handling as pointed out by Kevin. Fix
> error messages, and restore a couple of cases to their unreadable
> formatting to avoid formatting changes not directly related to the
> qcow_->qcow2_ rename.
> 
> Jes
> 
> Jes Sorensen (2):
>   block/qcow2.c: rename qcow_ functions to qcow2_
>   Add proper -errno error return values to qcow2_open()
> 
>  block/qcow2-cluster.c  |    6 +-
>  block/qcow2-snapshot.c |    6 +-
>  block/qcow2.c          |  248 +++++++++++++++++++++++++++---------------------
>  3 files changed, 145 insertions(+), 115 deletions(-)

Thanks, applied to the block branch.

Kevin