From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] test: add a script for STK conformance tests
Date: Fri, 17 Dec 2010 09:32:00 -0600 [thread overview]
Message-ID: <4D0B8270.9020003@gmail.com> (raw)
In-Reply-To: <9F3EABD6E3419B4C81F34EAABB4D40188136EF0453@irsmsx501.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
Hi Guillaume,
On 12/16/2010 10:04 AM, Lucas, GuillaumeX wrote:
> From: Guillaume Lucas <guillaumex.lucas@intel.com>
>
> To be able to run STK conformance tests at ofono
> level, we need to have a STK agent registered. The
> test-stk-conformance script provided here do that.
> This script is for conformance so all the data input
> of the agent are displayed to be able to check them.
> The existing test-stk-menu is usable only when there
> is a STK menu provided by the (U)SIM card.
> ---
> test/test-stk-conformance | 226 +++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 226 insertions(+), 0 deletions(-)
> create mode 100755 test/test-stk-conformance
>
I really don't like the amount of code copying going on here. Have you
considered extending the current test-stk-menu with the ability to run
as the 'default' agent instead? Maybe via a command line option?
Regards,
-Denis
next prev parent reply other threads:[~2010-12-17 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 16:04 [PATCH] test: add a script for STK conformance tests Lucas, GuillaumeX
2010-12-17 15:32 ` Denis Kenzior [this message]
2010-12-20 8:40 ` Lucas, GuillaumeX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0B8270.9020003@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.