Re: [PATCH 4/4] cifs: replace /proc/fs/cifs/Experimental with a module parm

[Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>]

On 12/08/2010 08:33 PM, Jeff Layton wrote:
> This flag currently only affects whether we allow "zero-copy" writes
> with signing enabled. Typically we map pages in the pagecache directly
> into the write request. If signing is enabled however and the contents
> of the page change after the signature is calculated but before the
> write is sent then the signature will be wrong. Servers typically
> respond to this by closing down the socket.
> 
> Still, this can provide a performance benefit so the "Experimental" flag
> was overloaded to allow this. That's really not a good place for this
> option however since it's not clear what that flag does.
> 
> Move that flag instead to a new module parameter that better describes
> its purpose. That's also better since it can be set at module insertion
> time by configuring modprobe.d.
> 
> Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  fs/cifs/README       |   16 ----------------
>  fs/cifs/cifs_debug.c |   43 -------------------------------------------
>  fs/cifs/cifsfs.c     |    6 ++++--
>  fs/cifs/cifsglob.h   |    2 +-
>  fs/cifs/file.c       |    4 ++--
>  5 files changed, 7 insertions(+), 64 deletions(-)
> 

Making it a module param sounds appropriate to me.

Reviewed-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>