All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff
Date: Fri, 17 Dec 2010 17:16:05 -0600	[thread overview]
Message-ID: <4D0BEF35.5000507@gmail.com> (raw)
In-Reply-To: <1292569471-20952-1-git-send-email-jeevaka.badrappan@elektrobit.com>

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

Hi Jeevaka,

On 12/17/2010 01:04 AM, Jeevaka Badrappan wrote:
> ---
>  src/call-forwarding.c |  243 ++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 241 insertions(+), 2 deletions(-)
> 

So I applied this patch but refactored it very heavily afterward.  Can
you do review the changes and make sure you're OK with them?  Can you
also submit the needed records for phonesim, so we can get those tested
as well?

I still have one concern with cfis_record_id selection logic.  There are
a couple of possibilities we might not be handling correctly:

- if no EFcfis records contain proper MSP ids
- if EFcfis record has a valid MSP id, but is relevant to teleservices
besides voice.  We still potentially select this record, even though a
voice specific record might or might not exist.

Overall I think we need to test this feature quite a bit more...

Regards,
-Denis

  reply	other threads:[~2010-12-17 23:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 18:56 Read/Write EFcfis/EFcphs-cff files-v4 Jeevaka Badrappan
2010-12-10 18:56 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-12-17  7:04   ` Jeevaka Badrappan
2010-12-17 23:16     ` Denis Kenzior [this message]
2010-12-10 18:56 ` [PATCH 2/7] ifx: Move call forwarding to post sim Jeevaka Badrappan
2010-12-10 18:56 ` [PATCH 3/7] isigen: " Jeevaka Badrappan
2010-12-10 18:56 ` [PATCH 4/7] plugins/n900: " Jeevaka Badrappan
2010-12-10 18:56 ` [PATCH 5/7] phonesim: " Jeevaka Badrappan
2010-12-10 18:56 ` [PATCH 6/7] doc: Add new property to call forwarding Jeevaka Badrappan
2010-12-10 18:56 ` [PATCH 7/7] TODO: Marking the Read/Write EFcfis task as done Jeevaka Badrappan
  -- strict thread matches above, loose matches on Subject: below --
2010-12-09 17:43 Read/Write EFcfis/EFcphs-cff files-v3 Jeevaka Badrappan
2010-12-09 17:43 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-12-07 20:37 Read/Write EFcfis/EFcphs-cff files Jeevaka Badrappan
2010-12-07 20:37 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-11-29 10:37 Read/Write EFcfis/EFcphs-cff Jeevaka Badrappan
2010-11-29 10:37 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-12-03 19:08   ` Denis Kenzior
2010-12-07 13:59     ` Jeevaka.Badrappan
2010-12-07 18:41       ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0BEF35.5000507@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.