From: Jens Scharsig <js_at_ng@scharsoft.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH alternate V3] at91rm9200: fix lowlevel_init() SMRDATA size
Date: Sat, 18 Dec 2010 13:30:04 +0100 [thread overview]
Message-ID: <4D0CA94C.2080405@scharsoft.de> (raw)
In-Reply-To: <1291361167-9880-1-git-send-email-biessmann@corscience.de>
* use start/end label for initialization tables instead of fix values
Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
---
I have trace through the code with JTAG. It should be work with
CONFIG_TEXT_BASE = 0x0 and CONFIG_TEXT_BASE=0x10000000.
Changes since first version:
* fix: remove on line to much (thanks Andreas Biessmann)
* fix: add _MTEXT_BASE instead of sub from table end
Changes since 2nd version:
* remove trailing whitespace
arch/arm/cpu/arm920t/at91/lowlevel_init.S | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/arm920t/at91/lowlevel_init.S b/arch/arm/cpu/arm920t/at91/lowlevel_init.S
index eaea9d2..8b58ba9 100644
--- a/arch/arm/cpu/arm920t/at91/lowlevel_init.S
+++ b/arch/arm/cpu/arm920t/at91/lowlevel_init.S
@@ -65,7 +65,8 @@ LoopOsc:
ldr r0, =SMRDATA
ldr r1, _MTEXT_BASE
sub r0, r0, r1
- add r2, r0, #80
+ ldr r2, =SMRDATAE
+ sub r2, r2, r1
pllloop:
/* the address */
ldr r1, [r0], #4
@@ -83,7 +84,8 @@ lock:
ldr r0, =SMRDATA1
ldr r1, _MTEXT_BASE
sub r0, r0, r1
- add r2, r0, #176
+ ldr r2, =SMRDATA1E
+ sub r2, r2, r1
sdinit:
/* the address */
ldr r1, [r0], #4
@@ -114,6 +116,7 @@ SMRDATA:
.word CONFIG_SYS_PLLBR_VAL
.word AT91_ASM_PMC_MCKR
.word CONFIG_SYS_MCKR_VAL
+SMRDATAE:
/* here there's a delay */
SMRDATA1:
.word AT91_ASM_PIOC_ASR
@@ -160,5 +163,6 @@ SMRDATA1:
.word CONFIG_SYS_SDRC_MR_VAL3
.word CONFIG_SYS_SDRAM
.word CONFIG_SYS_SDRAM_VAL
+SMRDATA1E:
/* SMRDATA1 is 176 bytes long */
#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
-- 1.7.1
next prev parent reply other threads:[~2010-12-18 12:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 7:26 [U-Boot] [PATCH] at91rm9200: fix lowlevel_init() SMRDATA size Andreas Bießmann
2010-12-03 17:09 ` Jens Scharsig
2010-12-03 21:22 ` Andreas Bießmann
2010-12-04 11:37 ` Jens Scharsig
2010-12-04 12:04 ` Albert ARIBAUD
2010-12-04 13:14 ` Andreas Bießmann
2010-12-04 18:18 ` Albert ARIBAUD
2010-12-04 10:53 ` [U-Boot] [PATCH alternate version] " Jens Scharsig
2010-12-04 13:12 ` Andreas Bießmann
2010-12-04 13:19 ` Andreas Bießmann
2010-12-05 8:12 ` [U-Boot] [PATCH alternate version V2] " Jens Scharsig
2010-12-05 10:16 ` Reinhard Meyer
2010-12-06 17:36 ` Jens Scharsig
2010-12-06 21:03 ` Andreas Bießmann
2010-12-12 19:12 ` Jens Scharsig
2010-12-17 7:55 ` Reinhard Meyer
2010-12-23 11:37 ` Andreas Bießmann
2010-12-18 12:30 ` Jens Scharsig [this message]
2010-12-23 11:39 ` [U-Boot] [PATCH alternate V3] " Andreas Bießmann
2010-12-23 12:13 ` Reinhard Meyer
2010-12-23 13:05 ` Jens Scharsig
2011-04-11 9:58 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0CA94C.2080405@scharsoft.de \
--to=js_at_ng@scharsoft.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.