From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: akpm@linux-foundation.org, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [cpuops cmpxchg double V1 1/4] Generic support for this_cpu_cmpxchg_double
Date: Sat, 18 Dec 2010 15:51:35 +0100 [thread overview]
Message-ID: <4D0CCA77.2040701@kernel.org> (raw)
In-Reply-To: <4D0CC982.3030905@kernel.org>
On 12/18/2010 03:47 PM, Tejun Heo wrote:
> This is ugly. :-( I think we should have made this_cpu_*() ops take
> pointers from the beginning. Anyways, that's too late, so is it
> completely impossible to make cmpxchg_double's take a scalar value?
> It can take the pointer all the same, no?
Also, the ratonale behind taking a scalar value instead of pointer was
that the operation changes what they do depending on the type of the
parameter (the size of the parameter), which is true for the double
ops too, so I think it would be better if we stick with lvalues.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-12-18 14:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 17:48 [cpuops cmpxchg double V1 0/4] this_cpu_cmpxchg_double support Christoph Lameter
2010-12-14 17:48 ` [cpuops cmpxchg double V1 1/4] Generic support for this_cpu_cmpxchg_double Christoph Lameter
2010-12-18 14:47 ` Tejun Heo
2010-12-18 14:51 ` Tejun Heo [this message]
2010-12-21 22:36 ` Christoph Lameter
2010-12-21 23:24 ` H. Peter Anvin
2010-12-22 9:14 ` Tejun Heo
2010-12-24 0:16 ` Christoph Lameter
2010-12-24 0:22 ` H. Peter Anvin
2010-12-25 4:53 ` Christoph Lameter
2010-12-25 6:11 ` H. Peter Anvin
2010-12-25 16:52 ` Tejun Heo
2010-12-25 23:55 ` Christoph Lameter
2010-12-27 10:52 ` Tejun Heo
2011-01-03 22:43 ` Christoph Lameter
2010-12-14 17:48 ` [cpuops cmpxchg double V1 2/4] x86: this_cpu_cmpxchg_double() support Christoph Lameter
2010-12-15 0:46 ` H. Peter Anvin
2010-12-15 0:56 ` H. Peter Anvin
2010-12-15 16:12 ` Christoph Lameter
2010-12-15 16:20 ` Christoph Lameter
2010-12-15 17:36 ` H. Peter Anvin
2010-12-15 17:53 ` Christoph Lameter
2010-12-15 16:32 ` H. Peter Anvin
2010-12-15 16:41 ` Christoph Lameter
2010-12-14 17:48 ` [cpuops cmpxchg double V1 3/4] slub: Get rid of slab_free_hook_irq() Christoph Lameter
2010-12-14 17:48 ` [cpuops cmpxchg double V1 4/4] Lockless (and preemptless) fastpaths for slub Christoph Lameter
2010-12-15 16:51 ` Tejun Heo
2010-12-15 16:55 ` Pekka Enberg
2010-12-15 16:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0CCA77.2040701@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.